Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create #4066 - Theme-controlled color scheme switch.md #12613

Merged
2 commits merged into from
Apr 12, 2022
Merged

Create #4066 - Theme-controlled color scheme switch.md #12613

2 commits merged into from
Apr 12, 2022

Conversation

arkthur
Copy link
Contributor

@arkthur arkthur commented Mar 3, 2022

Summary of the Pull Request

Specs for feature request "Theme-controlled color scheme switch".

References

#4066

@ghost
Copy link

ghost commented Mar 3, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@github-actions

This comment was marked as resolved.

Sign in to view
This was referenced Mar 3, 2022
Closed
Closed
@zadjii-msft
Copy link
Member

Thanks for the PR! I'm gonna tag this up so we discuss it during our next team sync next Monday.

@zadjii-msft zadjii-msft added the Needs-Discussion Something that requires a team discussion before we can proceed label Mar 3, 2022
@arkthur arkthur mentioned this pull request Mar 3, 2022
Closed
@arkthur
Copy link
Contributor Author

arkthur commented Mar 7, 2022

Thanks for the PR! I'm gonna tag this up so we discuss it during our next team sync next Monday.

Any news about this? I'm around in case anything is missing ;)

@zadjii-msft
Copy link
Member

Team sync usually isn't till later in the day on Mondays usually 😉 That being said, we've got a bunch of OOFages right now so I think we're gonna have to punt that meeting back a few days. Sorry for the delays 😬

@arkthur
Copy link
Contributor Author

arkthur commented Mar 7, 2022

I understand. I hope that meeting happens sooner than expected. In any case, I'll keep coming back in case more information is needed.

Thanks for the help until now :D

@zadjii-msft
Copy link
Member

Okay I owe you a longer reply in the morning, but the team was generally on board with this and happy with the spec. We've got tiny nits of things we might have added if we wrote it ourselves, but overall we're happy. I'll come back with those in the morning.

zadjii-msft
zadjii-msft approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, nits scattered throughout. Overall, we're jazzed to see a spec for this. We're also cautiously optimistic that implementation really shouldn't be all that difficult.

(we're also in a bit of a fire drill internally, and likely will be for a few weeks still, so sorry if this languishes a bit)

doc/specs/#4066 - Theme-controlled color scheme switch.md Show resolved Hide resolved
doc/specs/#4066 - Theme-controlled color scheme switch.md Show resolved Hide resolved
doc/specs/#4066 - Theme-controlled color scheme switch.md Show resolved Hide resolved
doc/specs/#4066 - Theme-controlled color scheme switch.md Show resolved Hide resolved
@zadjii-msft zadjii-msft added Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal. and removed Needs-Discussion Something that requires a team discussion before we can proceed labels Mar 10, 2022
miniksa
miniksa approved these changes Mar 11, 2022
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me!

@zadjii-msft
Copy link
Member

Sorry for the delays here. Team talked about this in sync and had verbal consensus on the spec, we should have merged this a while ago.

@zadjii-msft zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Apr 12, 2022
@ghost
Copy link

ghost commented Apr 12, 2022

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 7648411 into microsoft:main Apr 12, 2022
@arkthur arkthur deleted the patch-1 branch April 25, 2022 16:50
@ghost
Copy link

ghost commented May 24, 2022

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this pull request Jun 9, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Docs It's a documentation issue that really should be on MicrosoftDocs/Console-Docs Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arkthur @zadjii-msft @miniksa @raghavthind2005