Add automation properties to expander-style settings #13032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Accessibility
DHowett
reviewed
May 3, 2022
DHowett
reviewed
May 3, 2022
| @@ -146,6 +146,30 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation | |||
| } | |||
| } | |||
|
|
|||
| if (const auto& child{ GetTemplateChild(L"Expander") }) | |||
| { | |||
| if (const auto& expander{ child.try_as<Microsoft::UI::Xaml::Controls::Expander>() }) | |||
There was a problem hiding this comment.
This is just to ensure we have the correct control, right? If there was a template child named Expander we wouldn't want to give it these properties unless it actually was an expander?
There was a problem hiding this comment.
Yeah I like to think of this as just a sanity check! Would rather have it than not though
DHowett
reviewed
May 3, 2022
carlos-zamora
approved these changes
May 3, 2022
PankajBhojwani
commented
May 4, 2022
DHowett
reviewed
May 4, 2022
DHowett
approved these changes
May 4, 2022
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
carlos-zamora
pushed a commit
that referenced
this pull request
May 12, 2022
## Summary of the Pull Request Make sure we set `Name` and `FullDescription` on expander-style settings in the SUI ## PR Checklist * [x] Closes #13019 * [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA * [ ] Tests added/passed * [ ] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx * [ ] Schema updated. * [x] I work here ## Validation Steps Performed Accessibility insights now shows the name/full description for the expander-style settings (cherry picked from commit 71cbdc8) Service-Card-Id: 81446420 Service-Version: 1.13
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Make sure we set
NameandFullDescriptionon expander-style settings in the SUIPR Checklist
Validation Steps Performed
Accessibility insights now shows the name/full description for the expander-style settings