Remove outdated MSVC checks #13621
Merged
Remove outdated MSVC checks #13621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
commented
Jul 28, 2022
zadjii-msft
approved these changes
Jul 28, 2022
src/common.build.pre.props
Outdated
| --> | ||
| <DisableSpecificWarnings>4201;4312;4467;5105;26445;26813;%(DisableSpecificWarnings)</DisableSpecificWarnings> | ||
| <DisableSpecificWarnings Condition="'$(VCToolsVersion)' != '14.33.31629'">4201;4312;4467;5105;26445;26813;%(DisableSpecificWarnings)</DisableSpecificWarnings> | ||
| <DisableSpecificWarnings Condition="'$(VCToolsVersion)' == '14.33.31629'">4201;4312;4467;5105;26445;26813;26493;%(DisableSpecificWarnings)</DisableSpecificWarnings> |
There was a problem hiding this comment.
Is this gonna turn into a '$(VCToolsVersion)' > '14.33.31629' && '$(VCToolsVersion)' < 'some future version' in the future?
There was a problem hiding this comment.
I'm not sure why I never noticed but apparently this has been an issue for longer than that: https://godbolt.org/z/oanYPnzoc
So I'll just silently repurpose this PR to only remove the few Condition checks we don't need.
lhecker
added
the
Area-CodeHealth
lhecker
changed the title
carlos-zamora
approved these changes
Jul 28, 2022
carlos-zamora
added
the
AutoMerge
|
Hello @carlos-zamora! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes outdated checks for MSVC versions that we don't support anymore.