Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll to top when select all action is invoked #13656

Merged
1 commit merged into from
Aug 2, 2022
Merged

Scroll to top when select all action is invoked #13656

1 commit merged into from
Aug 2, 2022

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

In general, when a selection marker is shown, we should scroll to it. The selectAll action adds a selection marker, but we don't scroll to it. This PR makes it such that we do do that.

Epic: #4993
Closes #13485

@ghost ghost added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Aug 2, 2022
zadjii-msft
zadjii-msft reviewed Aug 2, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also trigger the marker to become visible?

@carlos-zamora
Copy link
Member Author

Does this also trigger the marker to become visible?

Yup!

@carlos-zamora carlos-zamora mentioned this pull request Aug 2, 2022
Merged
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Aug 2, 2022
@ghost ghost requested review from PankajBhojwani, DHowett and lhecker August 2, 2022 20:26
@carlos-zamora
Copy link
Member Author

@msftbot merge this in 5 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 2, 2022
@ghost
Copy link

ghost commented Aug 2, 2022

Hello @carlos-zamora!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 02 Aug 2022 20:48:51 GMT, which is in 5 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit a9c3b77 into main Aug 2, 2022
@ghost ghost deleted the dev/cazamor/bugfix/select-all-sln-marker branch August 2, 2022 20:49
carlos-zamora added a commit that referenced this pull request Aug 3, 2022
@carlos-zamora
[1.15] Scroll to sln marker for Mark Mode & SelectAll (#13660)
961925b 
Adds `ScrollToPoint()` from #13405 to be able to scroll to the selection marker when (1) mark mode is entered and (2) `selectAll` is called.

This change is a combination of #13656 and a minor part of #13405.
Epic: #4993
@ghost
Copy link

ghost commented Sep 13, 2022

🎉Windows Terminal Preview v1.16.252 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Sep 13, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

@DHowett DHowett Awaiting requested review from DHowett

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

select all marker visibility
3 participants
@carlos-zamora @zadjii-msft @PankajBhojwani