-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the ConPTY extended attributes optimization #13661
Changes from 9 commits
e476682
9dcc2da
863c35a
3748f52
f8ac846
e710300
433b168
824fa89
b02a8fe
bfaa4d2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -424,10 +424,15 @@ using namespace Microsoft::Console::Types; | |
// the inbox telnet client doesn't understand the Erase Character sequence, | ||
// and it uses xterm-ascii. This ensures that xterm and -256color consumers | ||
// get the enhancements, and telnet isn't broken. | ||
// | ||
// GH#13229: ECH and EL don't fill the space with "meta" attributes like | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I mean, don't we still have the "background" version of this problem? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. more tests you got it |
||
// underline, reverse video, hyperlinks, etc. If these spaces had those | ||
// attrs, then don't try and optimize them out. | ||
const auto optimalToUseECH = numSpaces > ERASE_CHARACTER_STRING_LENGTH; | ||
const auto useEraseChar = (optimalToUseECH) && | ||
(!_newBottomLine) && | ||
(!_clearedAllThisFrame); | ||
(!_clearedAllThisFrame) && | ||
(!_lastTextAttributes.HasAnyExtendedAttributes()); | ||
const auto printingBottomLine = coord.Y == _lastViewport.BottomInclusive(); | ||
|
||
// GH#5502 - If the background color of the "new bottom line" is different | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(fwiw: since
GetExtendedAttributes
doesn't do any translation or synthesis on its own, why should we use it instead of just using_extendedAttrs
directly?)