Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for fractional font sizes #14013

Merged
3 commits merged into from
Sep 16, 2022
Merged

Add support for fractional font sizes #14013

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87bb319
Add support for fractional font sizes
lhecker Sep 15, 2022
bfd208e
Round floats on write
lhecker Sep 16, 2022
8fb1d5c
Fix requestedSize.X rounding
lhecker Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/cascadia/TerminalSettingsModel/CascadiaSettingsSerialization.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1110,8 +1110,9 @@ void CascadiaSettings::WriteSettingsToDisk()

// write current settings to current settings file
Json::StreamWriterBuilder wbuilder;
wbuilder.settings_["indentation"] = " ";
wbuilder.settings_["enableYAMLCompatibility"] = true; // suppress spaces around colons
wbuilder.settings_["indentation"] = " ";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see you sorted this list ;P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's more than 1 line it must be sorted alphabetically! No exceptions! 😄

wbuilder.settings_["precision"] = 6; // prevent values like 1.1000000000000001

FILETIME lastWriteTime{};
const auto styledString{ Json::writeString(wbuilder, ToJson()) };
Expand Down