AtlasEngine: Partially revert glyph scaling changes #14085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
|
See these two comments for context: |
DHowett
approved these changes
Sep 27, 2022
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
DHowett
pushed a commit
that referenced
this pull request
Sep 28, 2022
This change fixes issues with certain fonts that draw _way_ outside the advance width/height black box and expect to remain centered on the baseline. ## Validation Steps Performed * Use MesloLGM Nerd Font * Print U+E0B0 * Ensure it's centered, even if it's cut off ✅ (cherry picked from commit 2de475b) Service-Card-Id: 85876935 Service-Version: 1.16
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes issues with certain fonts that draw way outside the advance
width/height black box and expect to remain centered on the baseline.
Validation Steps Performed