Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for broadcasting to all panes in a tab #14393
Add support for broadcasting to all panes in a tab #14393
Changes from 9 commits
c1fb748
1651994
8862ed8
d685c12
e21b6bb
8abe995
c1c002a
e29dc40
0136994
8d7c1ea
8a89d81
1813a42
521fdea
0627f8f
6ac4579
2860b4e
95dba3d
8894d80
0c9821c
20976f7
c1e4b7d
a5e66e2
fb90f25
7d2e6ad
2fb183a
bea849a
1a5852d
3cdb3db
aad2b68
5a78021
2dce177
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the scary for me - will a pane moved into a different tab continue broadcasting to the old tab? we don't do any event hookups or unhooks here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, works like a charm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh! Can you walk me through why it works?
As a reviewer I couldn't see the machinery that kept it safe. I'd rather know that we know the code is safe than that we tested and found the behavior safe 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I know this is gonna cause you physical pain to read:
TerminalPage::_HandleMovePane
TerminalPage::_MovePane
TerminalTab::DetachPane
Pane::DetachPane
this._DetachedHandlers
-> handled in a lambda inTerminalTab::_AttachEventHandlersToPane
TerminalTab::_DetachEventHandlersFromControl
TerminalTab::AttachPane