Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OSC777 - send notification #14425

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
ce375fa
send notifications, and get callbacks (in an entirely new instance. H…
zadjii-msft Sep 21, 2022
65bc163
stash, I never finished this before my kid was born
zadjii-msft Oct 31, 2022
67d8548
Merge branch 'main' into dev/migrie/fhl/7718-notifications
zadjii-msft Nov 21, 2022
006da6a
As a test, hook this up to BELs
zadjii-msft Nov 21, 2022
f0f75dc
Actually parse parameters from the notification
zadjii-msft Nov 21, 2022
e9b2e51
Plumbing is always the most work
zadjii-msft Nov 21, 2022
1fd87fe
only send when inactive
zadjii-msft Nov 22, 2022
054f173
cleanup
zadjii-msft Nov 22, 2022
0f339d2
revert some dead code
zadjii-msft Nov 22, 2022
8e170eb
oops
zadjii-msft Nov 22, 2022
3d83cc3
austinmode
zadjii-msft Nov 22, 2022
c4f623a
derp
zadjii-msft Nov 28, 2022
8b67ed7
more more austinmode
zadjii-msft Nov 28, 2022
9208222
I knew I forgot runformat
zadjii-msft Nov 28, 2022
cae6f04
Migrate spelling-0.0.21 changes from main
DHowett Nov 28, 2022
654416c
Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/7718-n…
zadjii-msft Nov 30, 2022
7b524b0
simple nits from review
zadjii-msft Dec 1, 2022
6ac5137
unpackaged and elevated hate him
zadjii-msft Dec 1, 2022
75ea5f3
Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/7718-n…
zadjii-msft Mar 3, 2023
dc448b4
Merge branch 'dev/migrie/fhl/7718-notifications' into dev/migrie/fhl/…
zadjii-msft Aug 24, 2023
3b02c96
summon didn't work but the rest did
zadjii-msft Aug 24, 2023
1726176
Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/7718-n…
zadjii-msft Aug 28, 2023
015c5e8
Merge remote-tracking branch 'origin/main' into dev/migrie/fhl/7718-n…
zadjii-msft Feb 7, 2024
8309901
We do want this
zadjii-msft Feb 7, 2024
4ab628d
we do not want this
zadjii-msft Feb 7, 2024
d234049
Revert "we do not want this"
zadjii-msft Feb 7, 2024
d3a98b3
Merge branch 'dev/migrie/fhl/7718-notifications' of https://github.co…
zadjii-msft Feb 7, 2024
eac27db
spel
zadjii-msft Feb 7, 2024
9a6ded2
comments, disable with velocity
zadjii-msft Feb 8, 2024
70d905b
add velocity, and a setting per-control for this
zadjii-msft Feb 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actions/spelling/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ File | Purpose | Format | Info
[reject.txt](reject.txt) | Remove words from the dictionary (after allow) | grep pattern matching whole dictionary words | [reject](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-reject)
[excludes.txt](excludes.txt) | Files to ignore entirely | perl regular expression | [excludes](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-excludes)
[patterns/*.txt](patterns/) | Patterns to ignore from checked lines | perl regular expression (order matters, first match wins) | [patterns](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-patterns)
[candidate.patterns](candidate.patterns) | Patterns that might be worth adding to [patterns.txt](patterns.txt) | perl regular expression with optional comment block introductions (all matches will be suggested) | [candidates](https://github.com/check-spelling/check-spelling/wiki/Feature:-Suggest-patterns)
[line_forbidden.patterns](line_forbidden.patterns) | Patterns to flag in checked lines | perl regular expression (order matters, first match wins) | [patterns](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-patterns)
[expect/*.txt](expect.txt) | Expected words that aren't in the dictionary | one word per line (sorted, alphabetically) | [expect](https://github.com/check-spelling/check-spelling/wiki/Configuration#expect)
[advice.md](advice.md) | Supplement for GitHub comment when unrecognized words are found | GitHub Markdown | [advice](https://github.com/check-spelling/check-spelling/wiki/Configuration-Examples%3A-advice)
Expand Down
2 changes: 1 addition & 1 deletion .github/actions/spelling/advice.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ See the `README.md` in each directory for more information.
:microscope: You can test your commits **without** *appending* to a PR by creating a new branch with that extra change and pushing it to your fork. The [check-spelling](https://github.com/marketplace/actions/check-spelling) action will run in response to your **push** -- it doesn't require an open pull request. By using such a branch, you can limit the number of typos your peers see you make. :wink:


<details><summary>:clamp: If the flagged items are false positives</summary>
<details><summary>If the flagged items are :exploding_head: false positives</summary>

If items relate to a ...
* binary file (or some other file you wouldn't want to check at all).
Expand Down
8 changes: 6 additions & 2 deletions .github/actions/spelling/allow/allow.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
admins
allcolors
apc
Apc
apc
breadcrumb
breadcrumbs
bsd
Expand All @@ -14,8 +14,8 @@ CMMI
copyable
cybersecurity
dalet
dcs
Dcs
dcs
dialytika
dje
downside
Expand All @@ -34,10 +34,12 @@ gantt
gcc
geeksforgeeks
ghe
github
gje
godbolt
hostname
hostnames
https
hyperlink
hyperlinking
hyperlinks
Expand Down Expand Up @@ -82,6 +84,7 @@ runtimes
shcha
slnt
Sos
ssh
timeline
timelines
timestamped
Expand All @@ -90,6 +93,7 @@ tokenizes
tonos
toolset
tshe
ubuntu
uiatextrange
UIs
und
Expand Down
Loading