Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing paths when items dropped from archive #14648

Merged
8 commits merged into from
Jan 11, 2023
Merged

Fix missing paths when items dropped from archive #14648

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0817366
fix: resolve missing items when dropped from archives
jiejasonliu Jan 7, 2023
80bf65f
build(TerminalControl): link shell32 library
jiejasonliu Jan 7, 2023
54e24d0
refactor: revert removed spacing
jiejasonliu Jan 7, 2023
aad902f
Apply suggestions from code review (const and gsl::narrow_cast)
carlos-zamora Jan 10, 2023
a548987
sorry I forgot the parens
carlos-zamora Jan 10, 2023
d92316c
Apply other suggestions from code review
DHowett Jan 10, 2023
4df6253
refactor: avoid extra copy
jiejasonliu Jan 10, 2023
88aacbd
Read directly into a wstring & move that into the vector
DHowett Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/cascadia/TerminalControl/TermControl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2562,10 +2562,9 @@ namespace winrt::Microsoft::Terminal::Control::implementation
else
{
fullPaths.reserve(items.Size());
for (auto item : items)
jiejasonliu marked this conversation as resolved.
Show resolved Hide resolved
for (const auto& item : items)
{
fullPaths.emplace_back(item.Path());

}
}

Expand Down