Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the window root to the profile page views, instead of the view model #14816

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Pass the window root to the profile page views, instead of the view model #14816

merged 4 commits into from
Feb 10, 2023

Conversation

PankajBhojwani
Copy link
Contributor

@PankajBhojwani PankajBhojwani commented Feb 9, 2023 •
edited by carlos-zamora
Loading

Summary of the Pull Request

Let the profile pages' views have access to the window root, rather than the ProfileViewModel. The window root is passed along when the page is navigated to.

Validation Steps Performed

Clicking Browse no longer crashes.

PR Checklist

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Settings UI Anything specific to the SUI Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. labels Feb 9, 2023
@PankajBhojwani PankajBhojwani changed the title Make sure to set window root on the profile VM Pass the window root to the profile page views, instead of the view model Feb 10, 2023
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Feb 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Second It's a PR that needs another sign-off label Feb 10, 2023
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Feb 10, 2023
@DHowett DHowett merged commit e4bba3c into main Feb 10, 2023
@DHowett DHowett deleted the dev/pabhoj/browse_fix branch February 10, 2023 23:39
@elsaco elsaco mentioned this pull request Feb 11, 2023
Closed
DHowett pushed a commit that referenced this pull request Mar 31, 2023
@PankajBhojwani @DHowett
Pass the window root to the profile page views, instead of the view m…
dd9e014 
…odel (#14816)

## Summary of the Pull Request
Let the profile pages' views have access to the window root, rather than the `ProfileViewModel`. The window root is passed along when the page is navigated to.

## Validation Steps Performed
Clicking `Browse` no longer crashes.

## PR Checklist
- [x] Closes #14808

(cherry picked from commit e4bba3c)
Service-Card-Id: 88031914
Service-Version: 1.17
@zadjii-msft zadjii-msft mentioned this pull request Apr 18, 2023
Closed
@j4james j4james mentioned this pull request Apr 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SUI "Browse..." button crashes
3 participants
@PankajBhojwani @DHowett @carlos-zamora