-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a useCommandline
property to the suggestions action
#15027
Merged
Merged
Changes from all commits
Commits
Show all changes
119 commits
Select commit
Hold shift + click to select a range
c96799c
Preview the input via the TSF input control. This is awesome, and sho…
zadjii-msft 1449088
bugfixes for the demo
zadjii-msft d3b5533
fix remaining bugs
zadjii-msft 0bda66f
a comment I missed
zadjii-msft ccfc834
Migrate spelling-0.0.21 changes from main
DHowett c97ac66
resart with fresh plumbing
zadjii-msft 7404dc3
zhu li, do the thing
zadjii-msft f361b6c
lots of removal of dead code from the sxnui
zadjii-msft b0fa972
make the menu mode compact, and remove the search box
zadjii-msft 985fcdb
better UX for typing
zadjii-msft e785bfc
Merge branch 'main' into dev/migrie/f/12861-preview-input
zadjii-msft 48e7348
small updates to the protocol
zadjii-msft 026f342
Merge remote-tracking branch 'origin/dev/migrie/f/3121-wE-dOnT-hAvE-d…
zadjii-msft ff5eead
Very important that the backspaces are trimmed from the preview
zadjii-msft 2c66c32
bottoms up bottoms up
zadjii-msft d94183b
icons are _slick_
zadjii-msft 8feb909
bottom-up mode is basically done
zadjii-msft f5909d9
Open in different directions based on available space
zadjii-msft 4516b4b
Properly account for the position of panes when opening the menu
zadjii-msft a3c4776
clamp horizontally
zadjii-msft 7988d89
code cleanup
zadjii-msft 84a41b4
cleanup _for review_?
zadjii-msft 36b5759
[PARENT] lmao I deleted the line that sends the inpu :facepalm"
zadjii-msft f3796da
mostly all the plumbing to get this back into a reasonable state
zadjii-msft f4c310a
make this actually work again
zadjii-msft dc71f0c
align to the cursor in bottoms up mode
zadjii-msft c9e7156
notes, cleanup, order the history correctly
zadjii-msft 5defde5
POC: We can take it out of the Popup and have it still work
zadjii-msft 57a5327
very confident we can get all the logic into the sxnui
zadjii-msft a172f53
Finish detaching it from the popup
zadjii-msft e2cc278
POC: We can take it out of the Popup and have it still work
zadjii-msft e544871
very confident we can get all the logic into the sxnui
zadjii-msft 173a830
Finish detaching it from the popup
zadjii-msft a21c815
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft 20f5651
final cleanup for review
zadjii-msft 236912a
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft 442413f
Final cleanup for review
zadjii-msft 9d5ef3a
format and spell
zadjii-msft cd2db82
Merge branch 'main' into dev/migrie/fhl-2023/pwsh-autocomplete-demo
zadjii-msft 22c94bf
spell
zadjii-msft 28555a6
Merge remote-tracking branch 'origin/main' into dev/migrie/fhl-2023/p…
zadjii-msft 36b676a
Add a setting to opt in, because feature flags are imprecise
zadjii-msft b096469
austin mode
zadjii-msft 4e46a63
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft 6c778a6
yea no I always run the tests
zadjii-msft 172a298
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft dfd4e27
Add a useCommandline property to the suggestions action
zadjii-msft 0c19591
This fixes a previewing issue, all the way back in the first PR
zadjii-msft db99537
Pre-filter the commands, and use the typed command to construct the s…
zadjii-msft 363c092
substr takes a count you dingus
zadjii-msft 4766b62
substr takes a count, not an end
zadjii-msft dea426a
And my command name
zadjii-msft 62fb61d
spell
zadjii-msft dc4a832
substr takes a count, not an end
zadjii-msft 19c1ed9
This fixes a previewing issue, all the way back in the first PR
zadjii-msft dd5458c
spell
zadjii-msft df92394
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft 51046c5
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft 2088d32
Add a range version of ROW::GetText
lhecker cc05133
Woops, wrong method
lhecker 11916fd
Merge remote-tracking branch 'origin/main' into dev/migrie/fhl-2023/p…
zadjii-msft 1c52862
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft 837c544
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft 3ea3860
this is so much cleaner
zadjii-msft d593fe1
Add a range version of ROW::GetText
lhecker f56d258
Woops, wrong method
lhecker 4c2499c
this is so much cleaner
zadjii-msft 057098e
Merge remote-tracking branch 'origin/main' into dev/migrie/fhl-2023/p…
zadjii-msft 62863f1
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' of https://gi…
zadjii-msft a530ccc
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft 920353a
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft 3fc364c
Merge branch 'main' into dev/migrie/fhl-2023/pwsh-autocomplete-demo
zadjii-msft fb40b5d
lazy loading for fun and profit
zadjii-msft d4422bb
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft 6575e5a
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft 2cf9f41
Merge branch 'main' into dev/migrie/fhl-2023/pwsh-autocomplete-demo
zadjii-msft b8d8f11
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft ad62ad8
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft 741b773
This needs to go way earlier in the stack of PRs
zadjii-msft 434572a
Merge branch 'main' into dev/migrie/fhl-2023/pwsh-autocomplete-demo
zadjii-msft 12d2160
minor code movement
zadjii-msft f10f14c
this is better
zadjii-msft 1a8275e
move code around
zadjii-msft 7ae4716
use less int math where possible
zadjii-msft 1720905
last refactoring - Open() instead of Anchor()
zadjii-msft 45a6e1d
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft 8879a1f
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft 27b3aac
this needed refactoring
zadjii-msft 7c3fd2a
Remove input previewing. We can necro later. It's too hacky
zadjii-msft 3ee1f9b
load bearing I guess
zadjii-msft ce70a37
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft 0bb3a8f
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft f9a764e
lots of load bearing code here
zadjii-msft a013020
Merge remote-tracking branch 'origin/main' into dev/migrie/fhl-2023/p…
zadjii-msft 0cf6475
whole pile of PR nits
zadjii-msft 902ee8e
raise the event relative to the sender
zadjii-msft 8f0b6f8
revert 1449088, d3b5533 and 0bda66f, because we didn't know what they…
zadjii-msft 4de9303
runformat
zadjii-msft 873d8d4
Merge remote-tracking branch 'origin/main' into dev/migrie/fhl-2023/p…
zadjii-msft a21977b
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft ff5ce00
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft 16492a7
fix the build
zadjii-msft 9070557
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft 1759213
oneliner mistakes
zadjii-msft c1339bc
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft a68f229
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft ef7f563
this would crash the palette if there were nested items
zadjii-msft 2bceb92
these are also vestigial
zadjii-msft 4110f2c
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft b7f8b36
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft dff4ae3
update my formatter so it stops blowing up
zadjii-msft 3748900
Merge branch 'dev/migrie/fhl-2023/pwsh-autocomplete-demo' into dev/mi…
zadjii-msft 8767448
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft f23c859
Apply suggestions from code review
zadjii-msft 1e91a1c
Merge remote-tracking branch 'origin/main' into dev/migrie/f/14779-sx…
zadjii-msft f84d139
remove comment
zadjii-msft 382983e
Merge branch 'dev/migrie/f/14779-sxnui-recent-commands' into dev/migr…
zadjii-msft 3be1201
Merge remote-tracking branch 'origin/main' into dev/migrie/f/sxnui-us…
zadjii-msft 54234a9
runformat
zadjii-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some thoughts:
\b
?fmt::format
below should useFMT_COMPILE
if possible.{:\x7f^{}}
withL""
andcurrentCommandline.size()
as the arguments. This will pad the empty string to be at least that many padding characters wide. (Forprintf()
functions you'd use the same technique.) Here's an example: https://godbolt.org/z/Gd5hfaqKj (The example uses narrow strings. You'd have to convert all of those arguments to wide strings for MSVC.)fmt::format
call on an extra line.Model::SendInputArgs
is a WinRT projection, shouldn't the argument technically be awinrt::param::hstring
and thus accept astd::wstring_view
as the argument? In that case you can drop thewinrt::hstring{}
wrapping.