Fix accuracy bugs around float/double/int conversions #15098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
lhecker
force-pushed
the
dev/lhecker/float-double-inaccuracy-bugs
branch
from
380e36f to
dc9e1db
Compare
lhecker
force-pushed
the
dev/lhecker/float-double-inaccuracy-bugs
branch
from
dc9e1db to
c8865d4
Compare
zadjii-msft
approved these changes
Apr 4, 2023
DHowett
approved these changes
Apr 4, 2023
| @@ -853,8 +852,7 @@ namespace winrt::Microsoft::Terminal::Control::implementation | |||
| // concerned with initialization process. Value forwarded to event handler. | |||
| void ControlCore::_updateFont(const bool initialUpdate) | |||
| { | |||
| const auto newDpi = static_cast<int>(static_cast<double>(USER_DEFAULT_SCREEN_DPI) * | |||
| _compositionScale); | |||
| const auto newDpi = static_cast<int>(lrint(_compositionScale * USER_DEFAULT_SCREEN_DPI)); | |||
There was a problem hiding this comment.
this cast seems extraneous or at the very best silly given the auto
There was a problem hiding this comment.
Otherwise AuditMode complains that long isn't automatically convertible to int (the parameter type for SetDPI).
|
@lhecker is this safe for 1.17 as well? |
|
Yeah I think this is safe. I've just checked it again and the only functional change is in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this bug while resizing my window on my 150% scale display.
Every 3 "snaps" of the window size, it would fail to resize the text
buffer. I found that this occurs, because we convert the swap chain
size from a float into a double, which converts my 597.333313 height
into 597.33331298828125, which then multiplied by 1.5 results in
895.999969482421875. If you just cast this to an integer, it'll
result in a height of 895px instead of the expected 896px.
This PR addresses the issue in two ways:
lrintorfloor, etc.PR Checklist