Fix reordering tabs mysteriously shuffling the actual backing tabs #15178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
This comment has been minimized.
This comment has been minimized.
DHowett
approved these changes
Apr 14, 2023
| @@ -4739,8 +4740,8 @@ namespace winrt::TerminalApp::implementation | |||
| } | |||
| } | |||
|
|
|||
| // `this` is safe to use | |||
| const auto request = winrt::make_self<RequestReceiveContentArgs>(src, _WindowProperties.WindowId(), index); | |||
| const auto myId{ _WindowProperties.WindowId() }; | |||
zadjii-msft
added
the
AutoMerge
lhecker
approved these changes
Apr 17, 2023
microsoft-github-policy-service
bot
deleted the
dev/migrie/b/15121-over-and-under-hill
branch
Merged
DHowett
pushed a commit
that referenced
this pull request
May 10, 2023
Reverts #15164, because that's fixed upstream now. Closes #15139. Reverts #15178, but also closes #15121, because that's fixed upstream. see also: * microsoft/microsoft-ui-xaml#8430 * microsoft/microsoft-ui-xaml#8420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: we stopped getting
TabView.TabItemsChanged. This meant that the tab view would change its apparent order, but we wouldn't change the backing tab order.I'm fixing this by grabbing the index of the tab that starts the drag, and the index of the tab view item at the end of the drag, and using that to reorder our backing list.
Closes #15121
Upstream microsoft/microsoft-ui-xaml#8388
Regressed in #15078 - I'm pretty confident about this, since I've got a 1.18.931 build of the Terminal with tear-out, but not MUX 2.8.