Fix AppInitialized latency metric #15206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
lhecker
force-pushed
the
dev/lhecker/fix-app-initialized-metric
branch
from
68a5778 to
09d7cdd
Compare
DHowett
approved these changes
Apr 19, 2023
lhecker
commented
Apr 19, 2023
| @@ -264,6 +263,8 @@ namespace winrt::TerminalApp::implementation | |||
| { | |||
| _root->SetFullscreen(true); | |||
| } | |||
|
|
|||
| AppLogic::Current()->NotifyRootInitialized(); | |||
There was a problem hiding this comment.
@zadjii-msft Is this the right way to get a handle to AppLogic? BTW given that App::Logic() returns a singleton, should we maybe remove static AppLogic logic; from there and move it into AppLogic::Current()? If there's a singleton, I feel like it's more idiomatic to create it inside the class of the singleton.
DHowett
force-pushed
the
dev/lhecker/fix-app-initialized-metric
branch
from
09d7cdd to
413963d
Compare
DHowett
force-pushed
the
dev/lhecker/startup-animations
branch
from
649f89b to
082aef0
Compare
DHowett
force-pushed
the
dev/lhecker/fix-app-initialized-metric
branch
from
413963d to
c599c02
Compare
DHowett
force-pushed
the
dev/lhecker/fix-app-initialized-metric
branch
from
c599c02 to
a248d8b
Compare
zadjii-msft
approved these changes
Apr 25, 2023
zadjii-msft
added
the
AutoMerge
|
@lhecker FYI looks like you have a little merge conflict you've gotta fix before merging this |
…nitialized-metric
microsoft-github-policy-service
bot
deleted the
dev/lhecker/fix-app-initialized-metric
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AppInitialized latency metric logs how long the application needs
to initialize the UI. 5b434dc broke this metric, because it was now
executing the code outside of the
Initializedcallback.It's the difference between a "latency" of ~50ms and ~350ms.
As an added bonus it moves the
_ApplyStartupTaskStateChangetaskinto the
Initializedcallback as well, because why not.Validation Steps Performed