Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also do the VisualState dance on the tab item #15217

Merged
merged 2 commits into from
Apr 24, 2023
Merged

Also do the VisualState dance on the tab item #15217

merged 2 commits into from
Apr 24, 2023

Conversation

zadjii-msft
Copy link
Member

Just changing the Theme also doesn't seem to work by itself - there seems to be a way for the tab to set the deselected foreground onto itself as it becomes selected. If the mouse isn't over the tab, that can result in mismatched fg/bg's

Regressed around #15078

Closes #15184

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels Apr 20, 2023
DHowett
DHowett approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

lhecker
lhecker approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@lhecker lhecker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

progress

@zadjii-msft zadjii-msft merged commit ee05307 into main Apr 24, 2023
@zadjii-msft zadjii-msft deleted the dev/migrie/b/15184-tab-text-black branch April 24, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tab title text sometimes becomes invisible when using the Light theme
3 participants
@zadjii-msft @DHowett @lhecker