Allow ROW::CopyRangeFrom to be vectorized #15267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Area-Performance
lhecker
force-pushed
the
dev/lhecker/vectorize-row
branch
from
928bcb0
to
2c14ae1
Compare
microsoft-github-policy-service
bot
requested review from
zadjii-msft,
PankajBhojwani,
carlos-zamora and
DHowett
lhecker
force-pushed
the
dev/lhecker/vectorize-row
branch
from
2c14ae1
to
56c7176
Compare
|
I've just rebased it on main due to a large number of conflicts. It requires another approval unfortunately. (cc @DHowett) |
zadjii-msft
approved these changes
Jun 22, 2023
microsoft-github-policy-service
bot
removed
the
Needs-Second
DHowett
approved these changes
Jun 22, 2023
DHowett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By rewriting the first major copy loop in
CopyRangeFromto usepointers/iterators instead of indices for iteration, the autovectorizer
kicks in end neatly rewrites it as an unrolled SIMD loop. This improves
performance during traditional window resizes by roughly 2x and will
be quite helpful in the future for our more complex reflow resize.
Unfortunately, MSVC unrolls the loop by 4x which is too much for our
purpose, but there's no option to change that. It's still better than
not having any vectorization however, since it kicks in at 32 columns.
It also renames the function to
CopyTextFrombe more in line withthe others and to avoid confusion, because it doesn't copy attributes.
Validation Steps Performed