Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the pending update version from the About dialog #15378

Merged
merged 1 commit into from
May 18, 2023
Merged

Remove the pending update version from the About dialog #15378

merged 1 commit into from
May 18, 2023

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented May 17, 2023

It turns out that the store API doesn't tell us what the new version is. We were loading up our own package and checking its version instead.

The best we can do is tell users that an update--any update--is available.

@DHowett
Remove the pending update version from the About Dialog
be6e458 
It turns out that the store API *doesn't* tell us what the new version
is. We were loading up our own package and checking its version instead.

The best we can do is tell users that an update--any update--is
available.
@DHowett DHowett added the Priority-0 Bugs that we consider release-blocking/recall-class (P0) label May 17, 2023
@DHowett DHowett changed the title Remove the pending update version from the About Dialog Remove the pending update version from the About dialog May 17, 2023
zadjii-msft
zadjii-msft approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes me h a t e things

lhecker
lhecker approved these changes May 18, 2023 •
edited
Loading
View reviewed changes
@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels May 18, 2023
@DHowett DHowett merged commit 125026d into main May 18, 2023
@DHowett DHowett deleted the dev/duhowett/updates-not-available-today branch May 18, 2023 15:22
@zadjii-msft zadjii-msft mentioned this pull request May 30, 2023
Closed
DHowett added a commit that referenced this pull request Sep 22, 2023
@DHowett
Remove the pending update version from the About dialog (#15378)
9b392de 
It turns out that the store API *doesn't* tell us what the new version
is. We were loading up our own package and checking its version instead.

The best we can do is tell users that an update--any update--is
available.

(cherry picked from commit 125026d)
Service-Card-Id: 89245539
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-Terminal The new Windows Terminal.
Projects
1.18 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DHowett @lhecker @zadjii-msft