Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually close the ContentDialog in teardown #15387

Merged
merged 1 commit into from
May 22, 2023
Merged

Manually close the ContentDialog in teardown #15387

merged 1 commit into from
May 22, 2023

Conversation

zadjii-msft
Copy link
Member

As discussed. Closes #15364.

Prevents one crash on Windows 10. Opens the door to may more horrors.

Co-authored by: @j4james

@zadjii-msft
Manually close the ContentDialog in teardown
19ef8cc 
As discussed. Closes #15364.

Prevents one crash on Windows 10. Opens the door to may more horrors.

Co-authored by: @j4james
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Windowing Window frame, quake mode, tearout Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels May 19, 2023
@DHowett
Copy link
Member

DHowett commented May 19, 2023

You will need to use the Signed-off-by: Name <e-mail> format when you actually merge this

DHowett
DHowett approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure @lhecker sees this too

@zadjii-msft zadjii-msft merged commit 910c61b into main May 22, 2023
@zadjii-msft zadjii-msft deleted the dev/migrie/b/15364-close-the-contentdialog-manually branch May 22, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows Terminal throws an exception on exit
3 participants
@zadjii-msft @DHowett @lhecker