-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refrigerate our threads for later reuse #15424
Merged
zadjii-msft
merged 23 commits into
main
from
dev/migrie/b/refrigerate-threads-for-later
Jul 19, 2023
Merged
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
19ef8cc
Manually close the ContentDialog in teardown
zadjii-msft 3241ef0
yea sure this works I guess
zadjii-msft bf95487
Merge remote-tracking branch 'origin/main' into dev/migrie/b/refriger…
zadjii-msft f3d6f6a
try to get the initial sizing right
zadjii-msft b0e80be
hey look it worked
zadjii-msft 0baf84c
some more minor code cleanup
zadjii-msft b6478ce
I think we can safely move this down
zadjii-msft fe08ad2
notes
zadjii-msft 7a85d66
egads this fixes #15410
zadjii-msft 242dfe5
Good enough to start
zadjii-msft 6f5b2f1
Merge remote-tracking branch 'origin/main' into dev/migrie/b/refriger…
zadjii-msft aaa9570
Merge remote-tracking branch 'origin/main' into dev/migrie/b/refriger…
zadjii-msft a3bfa21
spel and format
zadjii-msft b0994cd
fix actually most of the Windows 11 issues
zadjii-msft ffc5ebd
comments
zadjii-msft 44ef400
more notes
zadjii-msft 33546b7
spell
zadjii-msft b03c525
Update src/cascadia/WindowsTerminal/WindowEmperor.cpp
zadjii-msft 1a5e2ff
Merge remote-tracking branch 'origin/main' into dev/migrie/b/refriger…
zadjii-msft 47b2832
some of the more minor notes
zadjii-msft d2cf762
Merge remote-tracking branch 'origin/main' into dev/migrie/b/refriger…
zadjii-msft 957dd6f
Merge remote-tracking branch 'origin/main' into dev/migrie/b/refriger…
zadjii-msft 7650ef7
Last audit mode nits
zadjii-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK so this was my fear. We always pop off whatever kind of window we're given, and we never make sure it's the right kind. That means that on Windows 11 if I change "Show Tabs in Titlebar" new windows will get it right (no refrigeration) and on Windows 10 it may get it wrong (it will microwave the wrong kind of window).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a scale of 1-blocking, where do we rate this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would call it blocking for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brainstorm
HWND
HWND
IDesktopWindowXamlSourceNative::AttachToWindow
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just pin the setting for the entire duration the application is running? That's how the setting is documented anyways right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
man I'd love that. That would sure be the easiest way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er, after discussion, pinning probably isn't the best, cause warm-reloading
useTabsInTitlebar
does work on Windows 11 (and 10) today and would break if we did thatThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussing the impact with Mike, I'm choosing to not consider this blocking any longer.
It impacts the following scenario: