Exit the process after commandline-only invocations #15445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Issue-Bug
lhecker
reviewed
May 26, 2023
| @@ -109,7 +109,7 @@ bool WindowEmperor::HandleCommandlineArgs() | |||
| if (!res.Message.empty()) | |||
| { | |||
| AppHost::s_DisplayMessageBox(res); | |||
| ExitThread(res.ExitCode); | |||
| ExitProcess(res.ExitCode); | |||
There was a problem hiding this comment.
Could you call exit(res.ExitCode) instead? It'll call any atexit() handlers first and then call TerminateProcess instead of ExitProcess for immediate shutdown.
There was a problem hiding this comment.
Are you sure you want to run all our static deinitializers? ;)
There was a problem hiding this comment.
In that case I'd call quick_exit(). The implementation can be found at:
C:\Program Files (x86)\Windows Kits\10\Source\10.0.22621.0\ucrt\startup\exit.cpp
There was a problem hiding this comment.
There's also _Exit() btw, which is another proper C standard function (but I think quick_exit is the right choice). Using OS primitives here doesn't do us any favors as it breaks app verifier and other debugging tools.
DHowett
approved these changes
May 26, 2023
DHowett
changed the title
DHowett
changed the title
DHowett
pushed a commit
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yep it's that dumb
Closes #15443