AtlasEngine: Fix some Windows 10 <14393 bugs #15485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
|
I'm guessing we want to service this? |
No we don't need to. Windows Terminal's minimum build requirement is 19041, so it'll never hit this. It'll be a concern once we ship this to Visual Studio which then ships this to Windows 7/8/old-10. |
DHowett
approved these changes
Jun 2, 2023
microsoft-github-policy-service
bot
requested review from
zadjii-msft,
PankajBhojwani and
carlos-zamora
carlos-zamora
approved these changes
Jun 5, 2023
microsoft-github-policy-service
bot
removed
the
Needs-Second
DHowett
pushed a commit
that referenced
this pull request
Jul 27, 2023
This fixes a couple spots where I wasn't properly checking for the existence of some optional D2D interfaces. ## Validation Steps Performed I haven't tested this and don't intend to do it just yet. Windows Terminal requires build 19041 at least anyways. (cherry picked from commit f0705fb) Service-Card-Id: 89409006 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple spots where I wasn't properly checking
for the existence of some optional D2D interfaces.
Validation Steps Performed
I haven't tested this and don't intend to do it just yet.
Windows Terminal requires build 19041 at least anyways.