Fix a crash when duplicating tabs with elevate:true #15548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
approved these changes
Jun 14, 2023
carlos-zamora
approved these changes
Jun 14, 2023
lhecker
added
the
AutoMerge
microsoft-github-policy-service
bot
deleted the
dev/lhecker/15534-elevate-crash-fix
branch
DHowett
pushed a commit
that referenced
this pull request
Jul 27, 2023
When `elevate` is set to `true`, `_maybeElevate` would try to modify `newTerminalArgs` and crash, because during tab duplication there aren't any `newTerminalArgs`. This issue may happen for instance when receiving hand-off from a non-elevated client and then trying to duplicate that tab. Closes #15534 ## Validation Steps Performed * Launch with `"elevate": false` * Set `"elevate": true` * Duplicate a tab * Doesn't crash ✅ (cherry picked from commit 427b37c) Service-Card-Id: 89534065 Service-Version: 1.18
DHowett
pushed a commit
that referenced
this pull request
Aug 2, 2023
When `elevate` is set to `true`, `_maybeElevate` would try to modify `newTerminalArgs` and crash, because during tab duplication there aren't any `newTerminalArgs`. This issue may happen for instance when receiving hand-off from a non-elevated client and then trying to duplicate that tab. Closes #15534 * Launch with `"elevate": false` * Set `"elevate": true` * Duplicate a tab * Doesn't crash ✅ (cherry picked from commit 427b37c) Service-Card-Id: 89534064 Service-Version: 1.17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
elevateis set totrue,_maybeElevatewould try tomodify
newTerminalArgsand crash, because during tab duplicationthere aren't any
newTerminalArgs. This issue may happen for instancewhen receiving hand-off from a non-elevated client and then trying
to duplicate that tab.
Closes #15534
Validation Steps Performed
"elevate": false"elevate": true