Deduplicate INPUT_RECORD based ApiRoutines #15605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Product-Conhost
lhecker
commented
Jun 26, 2023
| @@ -22,8 +22,7 @@ | |||
| // - THROW: Throws E_INVALIDARG for invalid pointers. | |||
| DirectReadData::DirectReadData(_In_ InputBuffer* const pInputBuffer, | |||
| _In_ INPUT_READ_HANDLE_DATA* const pInputReadHandleData, | |||
| const size_t eventReadCount, | |||
| _In_ std::deque<std::unique_ptr<IInputEvent>> partialEvents) : | |||
There was a problem hiding this comment.
I forgot to remove this 4th parameter in a previous PR. I felt like this as good of a moment to remove it as any other.
lhecker
force-pushed
the
dev/lhecker/8000-ApiRoutines-cleanup
branch
from
967a521
to
288601e
Compare
DHowett
approved these changes
Jun 26, 2023
PankajBhojwani
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Peek|Read)ConsoleInput(A|W)Implmake a distinction that doesn't makea lot of sense in our code base: On the calling side (
ApiDispatchers)there's just one function calling all 4 (
ServerGetConsoleInput) andon the callee side they all 4 just call
_DoGetConsoleInputanyways.Validation Steps Performed