Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce GdiEngine input latency #15608

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Reduce GdiEngine input latency #15608

merged 1 commit into from
Jun 27, 2023

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jun 27, 2023

This commit reduces GdiEngine's average display latency by 8ms,
which caused it to miss a v-blank about half the time at 60Hz.

Closes #15607

Validation Steps Performed

Input latency with frarees/typometer matches conhost from Win10 ✅

@lhecker lhecker added Product-Conhost For issues in the Console codebase Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) labels Jun 27, 2023
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I can imagine a thousand tiny ways in which this will break stuff... but let's go for it!

Will this change the teardown behavior?

@lhecker
Copy link
Member Author

lhecker commented Jun 27, 2023

It'll only change the way _hPaintCompletedEvent works, because it might wait on an DWM event after having told our OneCore code that we're done rendering already. I don't see how waiting on an event might break anything.
And on the topic of OneCoreUAP I don't understand the code comments in the first place. RenderThread::WaitForPaintCompletionAndDisable talks about our renderer acquiring the display? I don't get it. Are you saying that we can get exclusive display ownership on OneCoreUAP? That'd be a fun step back to the 90s hahaha. Application is stuck/hung --> "Guess you can't alt-tab anymore. lol"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsiveness regression in Windows Console Host
3 participants