Make screen reader announce successful MovePane and MoveTab actions

[carlos-zamora]

Uses the RaiseNotificationEvent() API from UIA automation peers to announce successful MovePane and MoveTab actions. The announcements are localized in the resw file.

Closes #15159
Based on #13575

[DHowett]

This complies with the letter of the requirement, but does it comply with the spirit of the requirement? What does it mean for it to have been "moved successfully"?

[carlos-zamora]

This complies with the letter of the requirement, but does it comply with the spirit of the requirement? What does it mean for it to have been "moved successfully"?

Yeah, the associated bug isn't that descriptive. And I have trouble finding other apps that do this too (VS Code doesn't do it, and VS is notoriously noisy so I didn't bother to check), ugh.

All the associated bug says (even in the video) is that we need to say that we've moved successfully. So, it seems like the requirement is just to tell the user that the action was executed successfully.

@codeofdusk is there anything specific you'd expect the screen reader to say if you moved a tab or pane to another window?

[carlos-zamora]

The announcements now include a bunch more info. I tried building/deploying this commit, but I got a weird error down in the AcvtivationFactory that didn't really explain anything at runtime. I'll try building/deploying on my machine at home and I'll look into this more tomorrow. EDIT: verified it builds. I wanna verify all of these work and feel good but I can do that on my own.

For now, this should be in a good reviewable state though :)

Significant changes

[DHowett]

I'm not allergic to the OnCreateAutomationPeer change, but it scares me a little bit!

[lhecker]

It seems you can also write {Locked="{0}","{1}"}

[lhecker]

Do we have to construct the peer every time? Is it just a getter and cheap to call? Should we cache it? (I think this could be figured out by checking if the pointer that's returned is always the same. In that case it's probably a cheap getter.)

You could consider abstracting the code away like so:

void TerminalPage::_raiseActionCompletedEventforUIA(const std::wstring_view& activityId, const std::wstring_view& displayString) {
    using namespace ::winrt::Windows::UI::Xaml::Automation::Peers;
    if (auto autoPeer = FrameworkElementAutomationPeer::FromElement(*this))
    {
        autoPeer.RaiseNotificationEvent(
            AutomationNotificationKind::ActionCompleted,
            AutomationNotificationProcessing::ImportantMostRecent,
            displayString,
            activityId);
    }
}

So that the remaining code becomes:

_raiseActionCompletedEventforUIA(L"TerminalPageMovePaneToNewTab", RS_(L"TerminalPage_PaneMovedAnnouncement_NewTab"));

(etc.)

[DHowett]

FWIW this shouldn't construct but get the one from XAML's internal cache