Fix the prompt sometimes not being erased properly #15880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
Issue-Bug
zadjii-msft
added a commit
that referenced
this pull request
Aug 29, 2023
zadjii-msft
approved these changes
Sep 18, 2023
DHowett
added a commit
that referenced
this pull request
Sep 22, 2023
# Conflicts: # src/host/readDataCooked.hpp
DHowett
changed the title
DHowett
approved these changes
Sep 25, 2023
auto-merge was automatically disabled
September 26, 2023 00:24
Base branch was modified
DHowett
pushed a commit
that referenced
this pull request
Sep 26, 2023
A carriage return (enter key) will increase the _distanceEnd by up to viewport-width many columns, since it increases the Y distance between the start and end by 1 (it's a newline after all). This will make _flushBuffer() think that the new _buffer is way longer than the old one and so _erase() ends up not erasing the tail end of the prompt, even if the new prompt is actually shorter. This commit fixes the issue by separating the newline printing out from the regular text printing loops. ## Validation Steps Performed * Run cmd.exe * Write "echo hello" and press Enter * Write "foobar foo bar" (don't press Enter) * Press F7, select "echo hello" and press Enter * Previous prompt says "echo hello" ✅ (cherry picked from commit c7f30a8) Service-Card-Id: 90642765 Service-Version: 1.19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A carriage return (enter key) will increase the _distanceEnd by up to
viewport-width many columns, since it increases the Y distance between
the start and end by 1 (it's a newline after all).
This will make _flushBuffer() think that the new _buffer is way longer
than the old one and so _erase() ends up not erasing the tail end of
the prompt, even if the new prompt is actually shorter.
This commit fixes the issue by separating the newline printing
out from the regular text printing loops.
Validation Steps Performed