Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update close button visibility based on BOTH settings and readonly mode #15914

Merged
merged 4 commits into from
Sep 6, 2023
Merged

Update close button visibility based on BOTH settings and readonly mode #15914

merged 4 commits into from
Sep 6, 2023

Commits on Aug 31, 2023

  1. Update close button visibility based on BOTH settings and readonly mode 

    `TerminalTab::_RecalculateAndApplyReadOnly` didn't know about whether a tab should be closable or not, based on the theme settings. Similarly (though, unreported), the theme update in `TerminalPage::_updateAllTabCloseButtons` didn't really know about readonly mode.

This fixes both these issues by moving responsibility for the tab close button visibility into `TabBase` itself.

Closes #15902
    @zadjii-msft
    zadjii-msft committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    8c868bf View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Merge remote-tracking branch 'origin/main' into dev/migrie/b/15902-re… 

    …adonly-close-never
    @zadjii-msft
    zadjii-msft committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    5c421d0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into dev/migrie/b/15902-re… 

    …adonly-close-never
    @zadjii-msft
    zadjii-msft committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    88597fe View commit details
    Browse the repository at this point in the history

  3. comments make everyone happy

    @zadjii-msft
    zadjii-msft committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    45f254b View commit details
    Browse the repository at this point in the history