Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't explode if HKCU\Console is write-protected #15916

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Don't explode if HKCU\Console is write-protected #15916

merged 1 commit into from
Sep 5, 2023

Conversation

zadjii-msft
Copy link
Member

I manually changed the permissions on HKCU\Console to deny "Create subkey" to myself. Then confirmed that it explodes before this change, and not after this change.

Closes #15458

@zadjii-msft
Don't explode if HKCU\Console is write-protected
07d8303 
I manually changed the permissions on `HKCU\Console` to deny "Create subkey" to
myself. Then confirmed that it explodes before this change, and not after this
change.

Closes #15458
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Settings UI Anything specific to the SUI Priority-1 A description (P1) Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news. labels Aug 31, 2023
@DHowett DHowett enabled auto-merge (squash) August 31, 2023 17:10
@DHowett DHowett merged commit 6cff135 into main Sep 5, 2023
17 checks passed
@DHowett DHowett deleted the dev/migrie/b/15458-alabuzhev-reasons branch September 5, 2023 21:25
DHowett pushed a commit that referenced this pull request Sep 22, 2023
@zadjii-msft @DHowett
Don't explode if HKCU\Console is write-protected (#15916)
2007b9a 
I manually changed the permissions on `HKCU\Console` to deny "Create
subkey" to myself. Then confirmed that it explodes before this change,
and not after this change.

Closes #15458

(cherry picked from commit 6cff135)
Service-Card-Id: 90380920
Service-Version: 1.18
DHowett pushed a commit that referenced this pull request Nov 28, 2023
@zadjii-msft @DHowett
Don't explode if HKCU\Console is write-protected (#15916)
ce2a9ac 
I manually changed the permissions on `HKCU\Console` to deny "Create
subkey" to myself. Then confirmed that it explodes before this change,
and not after this change.

Closes #15458

(cherry picked from commit 6cff135)
Service-Card-Id: 90380919
Service-Version: 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Projects
1.17 Servicing Pipeline
Status: Cherry Picked
1.18 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WT crashes on saving settings when HKCU\Console is write-protected
3 participants
@zadjii-msft @DHowett @lhecker