Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows negative values in launch parameters #15941

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Allows negative values in launch parameters #15941

merged 2 commits into from
Sep 7, 2023

Conversation

codecruisedor
Copy link
Contributor

@codecruisedor codecruisedor commented Sep 7, 2023 •
edited
Loading

Added a style that allows negative values in the launch position parameters.

PR Checklist

@codecruisedor
Added new style in launch.xml
e8bc198 
Added a style that allows negative values in the lunch position parameters.
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-Settings UI Anything specific to the SUI Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Sep 7, 2023
@codecruisedor codecruisedor marked this pull request as draft September 7, 2023 20:26
@codecruisedor codecruisedor marked this pull request as ready for review September 7, 2023 20:30
@codecruisedor
Copy link
Contributor Author

codecruisedor commented Sep 7, 2023 •
edited
Loading

For some reason, the style that I added has extra spacing and is not formatted correctly. I formatted it correctly in VS. Did I miss something related to the clang-format?

@lhecker
Copy link
Member

lhecker commented Sep 7, 2023

If you launch PowerShell in the root directory of the repository you can run these 2 commands:

Import-Module .\tools\OpenConsole.psm1  # just once is enough
Invoke-CodeFormat                       # formats all files in the repository - useful for PRs

@codecruisedor
Formatted correctly
3c02ae5 
Correct formatting of the style added
@zadjii-msft zadjii-msft enabled auto-merge (squash) September 7, 2023 21:19
@zadjii-msft zadjii-msft merged commit 5d300b2 into microsoft:main Sep 7, 2023
12 of 14 checks passed
@DHowett
Copy link
Member

DHowett commented Sep 7, 2023 •
edited
Loading

Thanks for doing this! I've marked it up for backporting to 1.18 :)

@codecruisedor codecruisedor deleted the codecruisedor-new_style_to_allow_neg_launch_params branch September 16, 2023 05:48
DHowett pushed a commit that referenced this pull request Sep 22, 2023
@codecruisedor @DHowett
Allows negative values in launch parameters (#15941)
3cb78b2 
Added a style that allows negative values in the launch position
parameters.

## PR Checklist
- [x] Closes #15832

(cherry picked from commit 5d300b2)
Service-Card-Id: 90451445
Service-Version: 1.18
DHowett pushed a commit that referenced this pull request Nov 28, 2023
@codecruisedor @DHowett
Allows negative values in launch parameters (#15941)
ec0b257 
Added a style that allows negative values in the launch position
parameters.

## PR Checklist
- [x] Closes #15832

(cherry picked from commit 5d300b2)
Service-Card-Id: 90451444
Service-Version: 1.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
1.17 Servicing Pipeline
Status: Cherry Picked
1.18 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings / Startup / Launch Parameters / Launch Position doesn't allow Negative values
4 participants
@codecruisedor @lhecker @DHowett @zadjii-msft