Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash when the checking for updates without a network #16002

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Don't crash when the checking for updates without a network #16002

merged 1 commit into from
Sep 20, 2023

Conversation

zadjii-msft
Copy link
Member

You can't catch an A/V.

Closes #15459

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news. labels Sep 19, 2023
DHowett
DHowett reviewed Sep 19, 2023
View reviewed changes
src/cascadia/TerminalApp/AboutDialog.cpp
@@ -90,10 +90,13 @@ namespace winrt::TerminalApp::implementation
{
const auto updates = co_await storeContext.GetAppAndOptionalStorePackageUpdatesAsync();
co_await wil::resume_foreground(strongThis->Dispatcher());
const auto numUpdates = updates.Size();
if (numUpdates > 0)
if (updates)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: short circuit allows for if (updates && updates.Size() > 0) (which may also just read more svelte-ly

@lhecker
Copy link
Member

lhecker commented Sep 19, 2023

You can't catch an A/V.

Well........ 😄

@zadjii-msft zadjii-msft merged commit 523edd7 into main Sep 20, 2023
17 checks passed
@zadjii-msft zadjii-msft deleted the dev/migrie/b/15459-cant-catch-an-AV-fam branch September 20, 2023 11:35
DHowett pushed a commit that referenced this pull request Sep 22, 2023
@zadjii-msft @DHowett
Don't crash when the checking for updates without a network (#16002)
849d80d 
You can't catch an A/V.

Closes #15459

(cherry picked from commit 523edd7)
Service-Card-Id: 90584971
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Projects
1.18 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

About Dialog update check **crashes** after some time when network is slow or unreachable
3 participants
@zadjii-msft @lhecker @DHowett