Build unpackaged Canary distributions in portable mode #16048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I also added support to the unpackaged distribution script to produce portable mode packages. It is off by default for AppX->ZIP builds and **on** by default for Layout->ZIP builds. This constitutes a change in behavior.
DHowett
changed the title
lhecker
approved these changes
Sep 28, 2023
zadjii-msft
approved these changes
Sep 28, 2023
DHowett
added a commit
that referenced
this pull request
Sep 28, 2023
Unfortunately, the appLicensing restricted capability we used to make Canary installable without the store only works on Windows 11. Because of that, we have to restrict the app package to Windows 11 and above. I'd rather not leave Windows 10 users out in the cold, so this pull request also publishes Canary builds to the public storage bucket with the name `Microsoft.WindowsTerminalCanary_latest_x64.zip` (etc.) The version number will be kept inside the archive. It remains to be seen whether that is a good idea! When combined with #16048, Canary builds from Azure will automatically run in portable mode!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also added support to the unpackaged distribution script to produce portable mode packages. It is off by default for AppX->ZIP builds and on by default for Layout->ZIP builds.
This constitutes a change in behavior.