Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dismiss flyouts before opening warning dialog when exiting app #16075

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Dismiss flyouts before opening warning dialog when exiting app #16075

merged 1 commit into from
Oct 3, 2023

Conversation

codecruisedor
Copy link
Contributor

@codecruisedor codecruisedor commented Sep 30, 2023 •
edited
Loading

Updated the function TerminalPage::CloseWindow to include logic for closing context and flyout menus so that they are dismissed before the warning is displayed.

PR Checklist

@codecruisedor
Updated the TerminalPage::CloseWindow method
52863ab 
Updated the function to include logic for closing context and flyout menus.
@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Sep 30, 2023
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Oct 2, 2023
@carlos-zamora
Copy link
Member

Nice and easy. Thanks!

DHowett
DHowett approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Second It's a PR that needs another sign-off label Oct 3, 2023
@DHowett DHowett changed the title Dismiss flyout and context menus before opening warning dialog when exiting app Dismiss flyouts before opening warning dialog when exiting app Oct 3, 2023
@DHowett DHowett merged commit aafb917 into microsoft:main Oct 3, 2023
14 checks passed
DHowett pushed a commit that referenced this pull request Oct 3, 2023
@codecruisedor @DHowett
Dismiss flyouts before opening warning dialog when exiting app (#16075)
daf03ba 
Updated the function `TerminalPage::CloseWindow` to include logic for
closing context and flyout menus so that they are dismissed before the
warning is displayed.

Closes #16039

(cherry picked from commit aafb917)
Service-Card-Id: 90731988
Service-Version: 1.18
DHowett pushed a commit that referenced this pull request Oct 3, 2023
@codecruisedor @DHowett
Dismiss flyouts before opening warning dialog when exiting app (#16075)
f6e1126 
Updated the function `TerminalPage::CloseWindow` to include logic for
closing context and flyout menus so that they are dismissed before the
warning is displayed.

Closes #16039

(cherry picked from commit aafb917)
Service-Card-Id: 90731989
Service-Version: 1.19
@codecruisedor codecruisedor deleted the codecruisedor-close_contextandflyouts_before_closing branch October 4, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
1.18 Servicing Pipeline
Status: Shipped
1.19 Servicing Pipeline
Status: Shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Do you want to close all tabs?" content dialog is opened behind a menu flyout
3 participants
@codecruisedor @carlos-zamora @DHowett