Fix leak in buffering text for UIA when unfocused #16251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
lhecker
reviewed
Nov 1, 2023
src/renderer/uia/UiaRenderer.cpp
Outdated
| // If we had buffered any text from NotifyNewText, dump it. When we do come | ||
| // back around to actually paint, we will just no-op. No sense in keeping | ||
| // the data buffered. | ||
| _newOutput.clear(); |
There was a problem hiding this comment.
This will not release any memory however. Additionally, it also doesn't clear _queuedOutput. Do we need to do that?
This comment contains one approach to clear the memory in the EndPaint() method: #16209 (comment)
In the Disable() case I'd release the memory whenever, let's say, _newOutput.capacity() >= 4096 or something.
There was a problem hiding this comment.
Derp yea, we can resize it too.
I didn't think we needed to clear out _queuedOutput, since we might technically be after EndPaint, but in the middle of a Present.
DHowett
approved these changes
Nov 10, 2023
lhecker
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes in #16217 have the investigation.
TL;DR: we'd always buffer text. Even if we're disabled (unfocused). When we're
disabled, we'd never clear the buffered text. Oops.
Closes #16217