Replace caption buttons with ones that look close to correct #1627
Conversation
|
I am not an expert on Visual State manager, Alan Wu is our expert. |
|
@jevansaks could someone from control take a look at the VSM code. |
|
@DHowett-MSFT I am waiting for the merger of this PR. Yesterday I built Windows Terminal, it is really ugly, the window is not right angle, the black edge of the window (dark theme) makes me difficult to adapt. |
|
High contrast mode, X, hovered:
|
|
@DHowett-MSFT Great!!! |
Are you in high contrast black? I think buttons usually hover into light blue unless you've customized the colors. I'd expect:
If you've selected High Contrast #1 then I think that's right. Thanks! |
|
Oh, that’s weird. I actually just chose to enable high contrast with the keyboard shortcut. That said, I’m using the recommended high contrast brushes so it should be using high cyan for the other HC theme. |
There was a problem hiding this comment.
I am approving, but please wait for @jevansaks approval/suggestions.
| <x:String x:Key="CaptionButtonPath"></x:String> | ||
| <x:String x:Key="CaptionButtonPathWindowMaximized"></x:String> | ||
|
|
||
| <Style x:Key="CaptionButton" TargetType="Button"> |
There was a problem hiding this comment.
I think it might be helpful to add some comments explaining how this works for people who are less fluent in XAML (like me)
|
You're the man |
Summary of the Pull Request
This pull request contains a bunch of XAML that makes our caption buttons look like this:
instead of like the characters
_,-andXfrom Segoe UI.References
Part of #1625.
PR Checklist