Enable AtlasEngine by default #16277
Conversation
| @@ -90,7 +90,7 @@ Author(s): | |||
| X(hstring, TabTitle, "tabTitle") \ | |||
| X(Model::BellStyle, BellStyle, "bellStyle", BellStyle::Audible) \ | |||
| X(IEnvironmentVariableMap, EnvironmentVariables, "environment", nullptr) \ | |||
| X(bool, UseAtlasEngine, "useAtlasEngine", Feature_AtlasEngine::IsEnabled()) \ | |||
| X(bool, UseAtlasEngine, "useAtlasEngine", true) \ | |||
There was a problem hiding this comment.
I think for this period we'll want to change the name of the setting, so that people who opted out when it was broken get another chance to test it out. I was wondering if we should do that during Preview, though... 🤔
There was a problem hiding this comment.
Oh... We could check the AtlasEngine_Usage metric to see how many users opted out. This would tell us both, how many people this switch might (negatively) surprise and also whether introducing a new name for this setting is useful in the first place. Should we do that?
There was a problem hiding this comment.
might (negatively) surprise
To be fair, #16278 isn't going to do those people any favors 😆
There was a problem hiding this comment.
I need to regain access to Kusto to tell you about Atlas usage
There was a problem hiding this comment.
To be fair, #16278 isn't going to do those people any favors 😆
That's true, but it targets the 1.20 branch, so if there's anything in AtlasEngine that upsets an unreasonable amount of people, then I'll fix it ASAP before 1.20 is released as Preview.
|
I'd prefer to land this in main and then use the backport script to bring it in |
lhecker
added
Area-Settings
lhecker
added
the
AutoMerge
That's like a ChatGPT level hallucination 🤣 |
|
@DHowett The arm64 build got stuck because
Do you mind if we force-merge this? |
DHowett
removed
the
AutoMerge
This enables AtlasEngine by default in the 1.19 release branch. A future change will remove the alternative DxEngine entirely. (cherry picked from commit 204ebf3) Service-Card-Id: 91158876 Service-Version: 1.19
This enables AtlasEngine by default in the 1.19 release branch.
A future change will remove the alternative DxEngine entirely.