[CmdLineArgs] "--keepOpen" to keep the window/tab/pane open after the process/profile has exited.

[htcfreek]

Summary of the Pull Request

Adding a parameter to wt.exe that stops WT from closing after the sub process has exited.

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

This PR add the command line argument --keepOpen (short: -o) that stops WT from closing after the sub process has exited. This is done by overriding the Profile termination behavior setting at runtime with Never.

The new parameter is implemented as new-tab parameter and supports to be written to/read from a command line arguments JSON file.

Validation Steps Performed

• ✅ Tested that the new parameter is recognized on long and short form.
• 🔲 Tested that the new parameter stops WT from closing regardless of the current setting choice.
• 🔲 Tested that the new parameter not changes the setting permanently.
• ❌ Tested that the net tests succeed. => Added, but all command line tests are failing.
• 🔲 Tested the following parameter cases:

Command line	Result	Reason
wt.exe --keepOpen ping.exe learn.microsoft.com	❌
wt.exe --keepOpen cmd.exe /c echo "test"	❌
wt.exe -o cmd.exe /c echo "test"	❌
wt.exe new-tab --keepOpen PowerShell -c Get-Service	❌
wt.exe nt -p "Command Prompt" --keepOpen	❌
wt.exe nt -p "PowerShell" --keepOpen	❌
wt.exe nt -p "Windows PowerShell" -o	❌
wt.exe -p "Command Prompt" ; split-pane -p "PowerShell" --keepOpen	❌
wt.exe -p "Command Prompt" ; split-pane -p "PowerShell" -o	❌
wt.exe --keepOpen -p "Command Prompt" ; split-pane -p "PowerShell"	❌
wt.exe new-tab --keepOpen PowerShell --appendCommandLine -- Write-Host test	❌
wt.exe new-tab -o PowerShell --appendCommandLine -- Write-Host test	❌

PR Checklist

• Closes Add a parameter for --closeOnExit #16060
• Tests added/passed => Added, but not passed.
• Documentation updated
  • If checked, please file a pull request on our docs repo and link it here: #784
• Schema updated (if necessary)

[htcfreek]

@zadjii-msft
Status update: I have two important problems and need your help here.

1. wt.exe new-tab "PowerShell" --keepOpen -c Get-Service parses to the following command line: PowerShell --keepOpen -c Get-Service (Same when using the parameter --appendCommandLine -- Write-Host test.)
2. The settings of the profile are using the default value/value form settings.json and my parameter is ignored: What I need to know is, where can I manipulate the behavior of the profile/terminal?
3. [not important] wt.xe -? is incomplete and does not show the new parameter. (See my code comment.)

[htcfreek]

@zadjii-msft , @DHowett
Can you please look at this PR. I am not sure if it makes sense to keep it open as I don't know why it isn't working? Please give me some feedback.

[zadjii-msft]

My apologies! I think this one slipped through the cracks while I was off being distracted writing sudo. I can try and take a spin through the review - though, I might be a little more brief than usual until after Build (May 21-23)

[zadjii-msft]

honestly the rest of this looks like it should work

[zadjii-msft]

wt.exe new-tab "PowerShell" --keepOpen -c Get-Service

You'll probably want wt.exe new-tab -p "PowerShell" --keepOpen --appendCommandLine -c Get-Service (note the -p, to make sure it uses the PowerShell profile).

[htcfreek]

wt.exe new-tab "PowerShell" --keepOpen -c Get-Service

You'll probably want wt.exe new-tab -p "PowerShell" --keepOpen --appendCommandLine -c Get-Service (note the -p, to make sure it uses the PowerShell profile).

The problem was a wrong parameter order. Correct order is wt.exe new-tab --keepOpen "PowerShell" -c Get-Service

[htcfreek]

@zadjii-msft
I have updated the code to handle the command line setting now. But it doesn't work because closeMode is always the value from Profile settings and never the updated value after command line parsing. How can I get the updated value that I manipulate in the command line parser?

[htcfreek]

Opened issue #17473.

[htcfreek]

@zadjii-msft
All command line tests failed. The tests I have updated and the tests I did not changed.
The message is

    *********** CheckTypos - Test Start ***********
Trace Message: TerminalAppLocalTests::CommandlineTest::CheckTypos
	Message: 
	Result: Blocked
	Type: TestBlocked
	Context: TAEF
	File: 
	Function: 
	Timestamp: 01.01.0001 02:35:09
	Id: 106

*********** CheckTypos - Test Blocked ***********

What is happening here?