Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scratch.sln #16815

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix Scratch.sln #16815

merged 1 commit into from
Mar 7, 2024

Conversation

carlos-zamora
Copy link
Member

"ConptyConnection::CreateSettings()" was modified to include some extra parameters related to the environment variable changes. This just updates the call in Scratch.sln so that it builds and deploys properly.

@carlos-zamora
Copy link
Member Author

Here's the method signature to save you some time 😉

static Windows::Foundation::Collections::ValueSet CreateSettings(const winrt::hstring& cmdline,
const winrt::hstring& startingDirectory,
const winrt::hstring& startingTitle,
bool reloadEnvironmentVariables,
const winrt::hstring& initialEnvironment,
const Windows::Foundation::Collections::IMapView<hstring, hstring>& environmentOverrides,
uint32_t rows,
uint32_t columns,
const winrt::guid& guid,
const winrt::guid& profileGuid);

@zadjii-msft zadjii-msft merged commit 8a1e8ac into main Mar 7, 2024
20 checks passed
@zadjii-msft zadjii-msft deleted the dev/cazamor/fix-scratch branch March 7, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants