Clean up the Converters implementation #16820
Conversation
lhecker
added
the
Area-CodeHealth
| } | ||
|
|
||
| winrt::Windows::UI::Text::FontWeight Converters::DoubleToFontWeight(double value) | ||
| // Numbers | ||
| double Converters::PercentageToPercentageValue(double value) |
There was a problem hiding this comment.
Won't this cause the XAML UI to occasionally display something stupid like 99.000000000000000000000000001%?
There was a problem hiding this comment.
making the signature double (double), that is
There was a problem hiding this comment.
That's a good point. I'll test this. The only time this should occur is when we convert between float and double, so I'll just find and test all the places where we do that (shouldn't be too many?).
There was a problem hiding this comment.
This does result in something stupid like that, but not in the way you might have thought:
AppendPercentageSign has no limitation in the decimal places during stringification which results in these issues. It seems we simply didn't notice because we were lucky.
I thought the Converters.idl file had a really neat ordering,
and I felt like the .cpp implementation fell short of this.
This PR reorders the functions in the implementation to match the IDL.
It also gets rid of some unnecessary math (int vs. float, clamping)
and removes another use of
std::stringstream(= bad STL class).