Add Quick Fix UI and support for custom CommandNotFound OSC #16848

carlos-zamora · 2024-03-08T21:14:14Z

`OSC 9001; CmdNotFound; <missingCmd>`

Adds support for custom OSC "command not found" sequence OSC 9001; CmdNotFound; <missingCmd>. Upon receiving the "CmdNotFound" variant with the missing command payload, we send the missing command up to the Quick Fix menu and add it in as winget install <missingCmd>.

Quick Fix UI

The Quick Fix UI is a new UI surface that lives in the gutter (left padding) of your terminal. The button appears if quick fixes are available. When clicked, a list of suggestions appears in a flyout. If there is not enough space in the gutter, the button will be presented in a collapsed version that expands to a normal size upon hovering over it.

The Quick Fix UI was implemented similar to the context menu. The UI itself lives in TermControl, but it can be populated by other layers (i.e. TermApp layer).

Quick Fix suggestions are also automatically loaded into the Suggestions UI.

If a quick fix is available and a screen reader is attached, we dispatch an announcement that quick fixes are available to notify the user that that's the case.

Spec: #17005
#16599

Follow-ups

Add a key binding to open Quick Fix #17377: Add a key binding for quick fix
Improve OSC 9001; CmdNotFound suggestions #17378: Use winget to search for packages using missingCmd

src/cascadia/TerminalApp/Resources/en-US/Resources.resw

src/cascadia/TerminalApp/TerminalPage.cpp

src/cascadia/TerminalControl/EventArgs.idl

src/cascadia/TerminalSettingsModel/Command.cpp

carlos-zamora · 2024-03-26T22:15:25Z

src/cascadia/TerminalApp/AppActionHandlers.cpp

+                if (WI_IsFlagSet(source, SuggestionsSource::WinGetCommandNotFound) &&
+                    context != nullptr)
+                {
+                    const auto recentCommands = Command::ToSendInputCommands(context.WinGetSuggestions());
+                    for (const auto& t : recentCommands)
+                    {
+                        commandsCollection.push_back(t);
+                    }
+                }
+


@zadjii-msft is this kinda what you meant by adding the new suggestions to the context? If that's the case, we should rename the context to something else. Maybe ShellIntegrationContext?

Exactly what I was thinking. My quick recommendations:

I'd probably not name the member WinGetSuggestions, but instead QuickFixes. I'd think these should come through just the same as any other "quick fix" we add to the control (i.e. like a VT-driven one).

the same thing but with the flag in SuggestionsSource - that pobably also needs to get added to the JSON_FLAG_MAPPER in TerminalSettingsSerializationHelpers.h, as quickFixes

we probably want to pass a \uEA80 icon in here.

oofda I see the comment about the OEM icon below now. Well, similar idea I guess.

Oh huh, maybe we do want to give the winget suggestions a different icon. That's actually a really fun idea.

carlos-zamora · 2024-03-26T22:18:22Z

src/cascadia/TerminalControl/ControlCore.cpp

+        // TODO CARLOS: should we delete this after a new command is run? Or delete it after a suggestion is used? Or just after the next winget suggestion (current impl)?
+        //              No clue which we should do. Thoughts?
+        context->WinGetSuggestions(_cachedWinGetSuggestions);


@zadjii-msft thoughts on how to proceed here? I think...

delete after a new command is run: doable, but I'm not familiar with shell integration enough. If we wanna go this route, tips?

delete after a suggestion is used: this doesn't sound like something we can do easily. And also it doesn't sound like it'd feel totally right, imo.

delete after the next winget suggestion: I like that we don't hold on to stale suggestions, but I don't like that it's held on after another command is run.

Okay this is gonna sound like maybe a wacky idea, but what if we just stored these on the buffer, on the ROW itself? Kinda a bit like what I'm doing over in https://github.com/microsoft/terminal/pull/16937/files#diff-af0f626e5bb6718b60aa712a64c969e274f30968b5e24cc013318cf5c6badc12. If we just have one collection of suggestions per-row (a std::vector<wstring>), then we'd be able to just iterate up to the most recent collection of quick fixes, and only return those.

BUT even as I'm typing that up - I'd guess that a vector of strings, even an empty one, isn't low enough overhead to have the buffer go fast.

I guess a map of row->vector would work, but you'd have to deal with reflowing it and decrementing all rows on circling. Probably not terrible.

Knowing the row that the suggestion was printed on would also make drawing the icons more trivial.

another alternative / future thought - instead of just returning the most recent quick fix, you could further refine to be "the most recent quick fix if it was emitted in the most recent command with output". The most recent mark probably doesn't have output (it's just a prompt & possibly typed command), so keep looking backwards till you find one with output. Then only return quick fixes in that mark's extent.

Hmm... I'm leaning towards this idea:

I guess a map of row->vector would work, but you'd have to deal with reflowing it and decrementing all rows on circling. Probably not terrible.

We need to do this now so that we don't have the same suggestions appear forever. But the annoying thing is going to be that until quick fixes is implemented, we're just gonna hold on to the winget suggestions until they the buffer circles with no way to access them (since sxn ui can only be applied to the input line, right?). We can probably add some code in the interim that forces the map to only hold on to the most recent one, then undo that behavior as a part of quick fixes.

Another thing to point out here is that when the VT sequence is emitted, it'll be at the beginning of the "is not recognized..." line (where the flag is drawn in the image below)

So, this means that if there's multiple "is not recognized" messages, output from a command is going to have to consolidate all of them to suggest them as a quick fix on the next prompt. But without shell integration, we won't know which ones to consolidate.

As for this:

another alternative / future thought - instead of just returning the most recent quick fix, you could further refine to be "the most recent quick fix if it was emitted in the most recent command with output". The most recent mark probably doesn't have output (it's just a prompt & possibly typed command), so keep looking backwards till you find one with output. Then only return quick fixes in that mark's extent.

I like that idea a lot, but we can't rely on scroll marks existing since it requires changes to the shell, right?

So, if we're going to need shell integration anyways, perhaps the "the most recent quick fix if it was emitted in the most recent command with output" idea is best then. It just feels weird to couple it with shell integration 🤔

we're just gonna hold on to the winget suggestions

oh no a couple strings, oh nooooo /s. Honestly, if it's the right design in the next ~2 releases timeframe, then let's just do it right and not try and over-engineer the interim solution.

So, this means that if there's multiple "is not recognized" messages, output from a command is going to have to consolidate all of them to suggest them as a quick fix on the next prompt. But without shell integration, we won't know which ones to consolidate

If we store them as a property on the row, then we can do:

If there's a most recent prompt scroll mark, then get all the quick fixes from all the ROWs until that prompt

There's no shell integration? Then just get the quick fixes on the most recent ROW with quick fixes.

Basically, it works without shell integration, but it could work better with it

src/cascadia/TerminalSettingsModel/Command.cpp

zadjii-msft · 2024-03-27T11:02:51Z

src/cascadia/TerminalSettingsModel/Command.cpp

+            auto c = winrt::make_self<Command>();
+            c->_ActionAndArgs = actionAndArgs;
+            c->_name = command;
+            c->_iconPath = L"\ue74c"; // OEM icon


src/cascadia/TerminalSettingsModel/Command.cpp

src/cascadia/TerminalControl/ControlCore.cpp

zadjii-msft · 2024-03-27T11:17:56Z

src/cascadia/TerminalControl/ControlCore.cpp

+        // TODO CARLOS: should we delete this after a new command is run? Or delete it after a suggestion is used? Or just after the next winget suggestion (current impl)?
+        //              No clue which we should do. Thoughts?
+        context->WinGetSuggestions(_cachedWinGetSuggestions);


Okay this is gonna sound like maybe a wacky idea, but what if we just stored these on the buffer, on the ROW itself? Kinda a bit like what I'm doing over in https://github.com/microsoft/terminal/pull/16937/files#diff-af0f626e5bb6718b60aa712a64c969e274f30968b5e24cc013318cf5c6badc12. If we just have one collection of suggestions per-row (a std::vector<wstring>), then we'd be able to just iterate up to the most recent collection of quick fixes, and only return those.

BUT even as I'm typing that up - I'd guess that a vector of strings, even an empty one, isn't low enough overhead to have the buffer go fast.

I guess a map of row->vector would work, but you'd have to deal with reflowing it and decrementing all rows on circling. Probably not terrible.

Knowing the row that the suggestion was printed on would also make drawing the icons more trivial.

another alternative / future thought - instead of just returning the most recent quick fix, you could further refine to be "the most recent quick fix if it was emitted in the most recent command with output". The most recent mark probably doesn't have output (it's just a prompt & possibly typed command), so keep looking backwards till you find one with output. Then only return quick fixes in that mark's extent.

zadjii-msft · 2024-03-27T11:19:54Z

src/cascadia/TerminalApp/AppActionHandlers.cpp

+                if (WI_IsFlagSet(source, SuggestionsSource::WinGetCommandNotFound) &&
+                    context != nullptr)
+                {
+                    const auto recentCommands = Command::ToSendInputCommands(context.WinGetSuggestions());
+                    for (const auto& t : recentCommands)
+                    {
+                        commandsCollection.push_back(t);
+                    }
+                }
+


Exactly what I was thinking. My quick recommendations:

I'd probably not name the member WinGetSuggestions, but instead QuickFixes. I'd think these should come through just the same as any other "quick fix" we add to the control (i.e. like a VT-driven one).

the same thing but with the flag in SuggestionsSource - that pobably also needs to get added to the JSON_FLAG_MAPPER in TerminalSettingsSerializationHelpers.h, as quickFixes

we probably want to pass a \uEA80 icon in here.

zadjii-msft · 2024-03-27T11:20:32Z

src/cascadia/TerminalApp/AppActionHandlers.cpp

+                if (WI_IsFlagSet(source, SuggestionsSource::WinGetCommandNotFound) &&
+                    context != nullptr)
+                {
+                    const auto recentCommands = Command::ToSendInputCommands(context.WinGetSuggestions());
+                    for (const auto& t : recentCommands)
+                    {
+                        commandsCollection.push_back(t);
+                    }
+                }
+


oofda I see the comment about the OEM icon below now. Well, similar idea I guess.

zadjii-msft · 2024-03-27T11:21:33Z

src/cascadia/TerminalApp/AppActionHandlers.cpp

+                if (WI_IsFlagSet(source, SuggestionsSource::WinGetCommandNotFound) &&
+                    context != nullptr)
+                {
+                    const auto recentCommands = Command::ToSendInputCommands(context.WinGetSuggestions());
+                    for (const auto& t : recentCommands)
+                    {
+                        commandsCollection.push_back(t);
+                    }
+                }
+


Oh huh, maybe we do want to give the winget suggestions a different icon. That's actually a really fun idea.

src/cascadia/TerminalApp/TerminalPage.cpp

zadjii-msft · 2024-03-27T11:28:06Z

src/cascadia/TerminalApp/TerminalAppLib.vcxproj

@@ -439,6 +439,11 @@
      <ResolvedFrom>CppWinRTImplicitlyExpandTargetPlatform</ResolvedFrom>
      <IsSystemReference>True</IsSystemReference>
    </Reference>
+    <Reference Include="$(OpenConsoleDir)src\cascadia\TerminalApp\Microsoft.Management.Deployment.winmd">


but also, just adding this here, is that enough to actually let our package know what dll these types are implemented in? Or do we need to do something to make sure the winget package (that presumably implements these) is actually in our package graph?

No clue! This and this comment are gonna be my next step (figuring out how to actually interact with WinGet).

a thought: stage this as two PRs.

this first one: plumbing, store the "quick fix" in the buffer, plumb into sxnui. But only store a blind winget install foo, don't actually do the package lookup.

probably just hide this behind velocity into canary only for the time being

a second PR that enlightens the suggestion to include real winget results for foo.

carlos-zamora · 2024-04-26T21:56:51Z

Demo (Outdated but kept around for full interaction)

See #16848 (comment) for updated design

Non-Collapsed (Normal)

Collapsed

zadjii-msft

Okay, I think I'm ready to sign off on this as a "this is canary, lets play with it and iterate" feature.

I think I have enough Q's here though to warrant a block.

My main one being: I thought we'd have the collapsed version always be like, max(2, padding.Left)dips wide (even covering part of the prompt!), but then always expand out to 16 (or font.Height or whatever) when hovered.

This is enough other plumbing that I think I'm fine saying "polish in post" but I just want to have plans on the record first ☺️

src/features.xml

zadjii-msft · 2024-05-31T19:07:30Z

src/cascadia/TerminalApp/TerminalPage.cpp

+
+        std::vector<hstring> suggestions;
+        suggestions.reserve(1);
+        suggestions.emplace_back(fmt::format(L"winget install {}", args.MissingCommand()));


📝 this doesn't actually do the winget lookup for args.MissingCommand, but we are including the winget winmd?

Oops. Yeah, we're blocked by winget. Internally tracking here.

Removed any references to the WinMD since we're not actually using it.

src/cascadia/TerminalApp/TerminalPage.cpp

src/cascadia/TerminalControl/ControlCore.cpp

zadjii-msft · 2024-05-31T19:13:40Z

src/cascadia/TerminalControl/ControlCore.cpp

@@ -1612,6 +1620,16 @@ namespace winrt::Microsoft::Terminal::Control::implementation
        _midiAudio.PlayNote(reinterpret_cast<HWND>(_owningHwnd), noteNumber, velocity, std::chrono::duration_cast<std::chrono::milliseconds>(duration));
    }

+    void ControlCore::_terminalSearchMissingCommand(std::wstring_view missingCommand)
+    {
+        SearchMissingCommand.raise(*this, make<implementation::SearchMissingCommandEventArgs>(hstring{ missingCommand }));


📝 this goes up on the BG thread, then comes back down into us in UpdateQuickFixes on the UI thread

src/cascadia/TerminalControl/TermControl.cpp

…ess some other feedback

lhecker

Most of the things I can think of are nits, that aren't really worth mentioning.

src/cascadia/TerminalApp/TerminalPage.cpp

src/cascadia/TerminalControl/TermControl.cpp

lhecker · 2024-06-10T23:38:29Z

It may be worth mentioning here as well that the 2 (?) functions in Windows Terminal that use \x7f to clear parts of the prompt are broken for non-Latin languages. This appears to include this PR as it's based on Command::HistoryToCommands. (The other place is _filterToSendInput. This doesn't seem to apply to ParsePowerShellMenuComplete since the backspace count stems from the shell itself via a VT sequence.)

The 2 functions correlate the number of characters with the number of backspaces. But that's not how grapheme clusters, combining characters, etc. work. I don't have the big picture understanding to how the \x7f backspaces are used exactly, but I'm convinced they aren't generated correctly at least. I think we probably can't ship this feature (or any other feature that depends on this indirectly) as stable until we addressed this. It's possible that simply using CodepointWidthDetector from my graphemes PR would already fix this issue, since it lets you count the number of graphemes in a string. Additionally, if all we want is to clear a prompt completely, we should IMO emit a single Esc instead of multiple backspaces, since that will always work independent of the prompt contents.

DHowett

Blocking until the spec is reviewed

zadjii-msft · 2024-06-22T11:38:08Z

(@DHowett we could probably merge this even while carlos is out)

DHowett

Alright, the only thing I'm actually blocking over is the bad conflict resolution in TerminalCore.h! This looks really good. Well done.

DHowett · 2024-06-28T20:07:45Z

src/cascadia/TerminalControl/ControlCore.cpp

+    void ControlCore::ClearQuickFix()
+    {
+        _cachedQuickFixes = nullptr;
+        RefreshQuickFixUI.raise(*this, nullptr);


mildly alarmed that ClearQuickFix seems to refresh the QF UI but UpdateQuickFixes doesn't

DHowett · 2024-06-28T20:08:06Z

src/cascadia/TerminalControl/ControlCore.cpp

+        return _cachedQuickFixes && _cachedQuickFixes.Size() > 0;
+    }
+
+    void ControlCore::UpdateQuickFixes(const Windows::Foundation::Collections::IVector<hstring>& quickFixes)


this is more of a Set than an Update. Update is like "do it on your own". Set is more like "i will give it to you"

DHowett · 2024-06-28T20:09:15Z

src/cascadia/TerminalControl/ControlCore.h

@@ -354,6 +362,9 @@ namespace winrt::Microsoft::Terminal::Control::implementation

        til::point _contextMenuBufferPosition{ 0, 0 };

+        Windows::Foundation::Collections::IVector<int32_t> _cachedSearchResultRows{ nullptr };


what is this?

it looks like a line that was removed in #17132. bad conflict resolution?

DHowett · 2024-06-28T20:15:42Z

src/cascadia/TerminalCore/Terminal.cpp

-    //
-    // Then treat this line like it's a prompt mark.
-    if (_autoMarkPrompts && vkey == VK_RETURN && !_inAltBuffer())
+    if (vkey == VK_RETURN && !_inAltBuffer())


quick fix is cleared if we're not in the alt buffer. do we have a way to hide it if you enter the alt buffer?

cmd may never do this, so it may be moot

src/cascadia/TerminalSettingsModel/Command.cpp

src/cascadia/TerminalControl/ControlCore.h

DHowett · 2024-06-28T22:52:03Z

Ohhh crap it conflicts with the renderer changes on main.

This comment was marked as outdated.

Sign in to view

zadjii-msft mentioned this pull request Mar 22, 2024

Command Decorations / Marks in the gutter / margin / padding #16599

Open

carlos-zamora added 3 commits March 26, 2024 10:49

Add support for custom CommandNotFound OSC

12100c5

[Broken] Properly search through WinGet's catalog

c8d13d4

add debug code & dismiss button

534c2d9

carlos-zamora force-pushed the dev/cazamor/cmdNotFound branch from 779cda8 to 534c2d9 Compare March 26, 2024 17:52

carlos-zamora added 2 commits March 26, 2024 11:14

remove info bar code; fix branch

c1e1eab

use suggestions UI instead

68ed03d

carlos-zamora commented Mar 26, 2024

View reviewed changes

add a lil polish

c2417bb

carlos-zamora force-pushed the dev/cazamor/cmdNotFound branch from 222e334 to c2417bb Compare March 26, 2024 22:31

zadjii-msft reviewed Mar 27, 2024

View reviewed changes

carlos-zamora added 6 commits March 27, 2024 16:29

address feedback; winget integration still in progress

6a361ef

Merge branch 'main' into dev/cazamor/cmdNotFound

a2e57b4

moar progress! (useTransitions -> crash!)

cfaa09d

fix design

88b64cd

Merge branch 'main' into dev/cazamor/cmdNotFound

48a36be

feature flag; fix scroll bug; clear QF on enter

d8c8807

carlos-zamora marked this pull request as ready for review April 26, 2024 21:55

carlos-zamora requested a review from zadjii-msft April 26, 2024 21:57

clear quick fix on interaction

8c0d7c6

zadjii-msft added this to the Terminal v1.22 milestone May 31, 2024

zadjii-msft requested changes May 31, 2024

View reviewed changes

microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 31, 2024

Merge branch 'main' into dev/cazamor/cmdNotFound

ec1fbc2

microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 3, 2024

zadjii-msft added a commit that referenced this pull request Jun 3, 2024

PRE-MERGE #16848 Add support for custom CommandNotFound OSC

4485e50

remove feature flag and WinMD refs; add QuickFixesAvailable API; addr…

767692c

…ess some other feedback

remove the winmd we're not using anymore

755f121

This was referenced Jun 5, 2024

Add a key binding to open Quick Fix #17377

Closed

Improve OSC 9001; CmdNotFound suggestions #17378

Closed

carlos-zamora assigned zadjii-msft Jun 6, 2024

lhecker approved these changes Jun 10, 2024

View reviewed changes

src/cascadia/TerminalApp/TerminalPage.cpp Outdated Show resolved Hide resolved

src/cascadia/TerminalApp/TerminalPage.cpp Show resolved Hide resolved

src/cascadia/TerminalControl/TermControl.cpp Outdated Show resolved Hide resolved

DHowett requested changes Jun 11, 2024

View reviewed changes

microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 11, 2024

zadjii-msft approved these changes Jun 11, 2024

View reviewed changes

carlos-zamora unassigned zadjii-msft Jun 12, 2024

microsoft-github-policy-service bot removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jun 12, 2024

carlos-zamora added 2 commits June 12, 2024 16:07

re-add feature flag; address Leonard's comments

a0aa2d0

Merge branch 'main' into dev/cazamor/cmdNotFound

1ffbae1

carlos-zamora assigned DHowett Jun 13, 2024

DHowett approved these changes Jun 28, 2024

View reviewed changes

DHowett reviewed Jun 28, 2024

View reviewed changes

src/cascadia/TerminalControl/ControlCore.h Outdated Show resolved Hide resolved

Apply suggestions from code review

0c5d880

DHowett enabled auto-merge June 28, 2024 20:19

lhecker approved these changes Jun 28, 2024

View reviewed changes

DHowett added 2 commits June 28, 2024 17:52

Merge remote-tracking branch 'origin/main' into dev/cazamor/cmdNotFound

ef6af81

Adjust for renderer changes on main

db7f464

DHowett disabled auto-merge June 28, 2024 22:53

DHowett enabled auto-merge June 28, 2024 22:54

lhecker approved these changes Jun 28, 2024

View reviewed changes

DHowett added this pull request to the merge queue Jun 28, 2024

Merged via the queue into main with commit 6589957 Jun 29, 2024
22 checks passed

DHowett deleted the dev/cazamor/cmdNotFound branch June 29, 2024 00:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Quick Fix UI and support for custom CommandNotFound OSC #16848

Add Quick Fix UI and support for custom CommandNotFound OSC #16848

carlos-zamora commented Mar 8, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

carlos-zamora Mar 26, 2024

zadjii-msft Mar 27, 2024

zadjii-msft Mar 27, 2024

zadjii-msft Mar 27, 2024

carlos-zamora Mar 26, 2024

zadjii-msft Mar 27, 2024

carlos-zamora Mar 27, 2024

zadjii-msft Apr 1, 2024

zadjii-msft Mar 27, 2024

zadjii-msft Mar 27, 2024

zadjii-msft Mar 27, 2024

zadjii-msft Mar 27, 2024

zadjii-msft Mar 27, 2024

zadjii-msft Mar 27, 2024

carlos-zamora Mar 27, 2024

zadjii-msft Apr 1, 2024

carlos-zamora commented Apr 26, 2024 •

edited

Loading

zadjii-msft left a comment

zadjii-msft May 31, 2024

carlos-zamora Jun 3, 2024

zadjii-msft May 31, 2024

lhecker left a comment

lhecker commented Jun 10, 2024 •

edited

Loading

DHowett left a comment

zadjii-msft commented Jun 22, 2024

DHowett left a comment

DHowett Jun 28, 2024

DHowett Jun 28, 2024

DHowett Jun 28, 2024

DHowett Jun 28, 2024

DHowett Jun 28, 2024

DHowett commented Jun 28, 2024

		@@ -354,6 +362,9 @@ namespace winrt::Microsoft::Terminal::Control::implementation

		til::point _contextMenuBufferPosition{ 0, 0 };

		Windows::Foundation::Collections::IVector<int32_t> _cachedSearchResultRows{ nullptr };

Add Quick Fix UI and support for custom CommandNotFound OSC #16848

Add Quick Fix UI and support for custom CommandNotFound OSC #16848

Conversation

carlos-zamora commented Mar 8, 2024 • edited Loading

OSC 9001; CmdNotFound; <missingCmd>

Quick Fix UI

Follow-ups

This comment was marked as outdated.

This comment was marked as outdated.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

carlos-zamora commented Apr 26, 2024 • edited Loading

Demo (Outdated but kept around for full interaction)

Non-Collapsed (Normal)

Collapsed

zadjii-msft left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lhecker left a comment

Choose a reason for hiding this comment

lhecker commented Jun 10, 2024 • edited Loading

DHowett left a comment

Choose a reason for hiding this comment

zadjii-msft commented Jun 22, 2024

DHowett left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DHowett commented Jun 28, 2024

carlos-zamora commented Mar 8, 2024 •

edited

Loading

`OSC 9001; CmdNotFound; <missingCmd>`

carlos-zamora commented Apr 26, 2024 •

edited

Loading

lhecker commented Jun 10, 2024 •

edited

Loading