-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1536 - Feature Request - Duplicate tab #1685
Conversation
…CTRL + SHIFT + D)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please run the Code Formatter located in tools\OpenConsole.psm1
Other than that, pretty straightforward. Thanks!
Awesome feature that is needed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix tabs/spacing issues and I think its good
@miniksa You were right. I did not set this option in Visual Studio in the first place. The changes are made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this, but I'm going to try to see why the line Carlos marked is a diff despite looking exactly the same before I hit the merge button.
🎉 Handy links: |
Added keybinding option to duplicate focused tab
Summary of the Pull Request
Added necessary delcarations and implmentations to provide a new keybinding for duplicating the focused tab.
References
PR Checklist
added/passedN/ADetailed Description of the Pull Request / Additional comments
As discussed in this issue, a simple implementation for duplicating the focused tab was made by me.
I added the needed declarations for the new keybinding and added a method to duplicate the focused tab in
App.cpp
.Validation Steps Performed
profiles.json
"command" : "duplicateTab"
"keys": [ "ctrl+shift+d" ]