Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: roll back to a build container with the 14.38 compiler #16907

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Mar 20, 2024

The 14.39 compiler seems pretty busted.

Refs #16794

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything is awful

@DHowett
Copy link
Member Author

DHowett commented Mar 20, 2024

i'll hold this until the canary build completes and I can share a binary with the folks in that thread.

@DHowett DHowett merged commit ff47e0c into main Mar 20, 2024
20 checks passed
@DHowett DHowett deleted the dev/duhowett/ci-vprev branch March 20, 2024 20:52
DHowett added a commit that referenced this pull request Mar 20, 2024
The 14.39 compiler seems pretty busted.

Refs #16794

(cherry picked from commit ff47e0c)
Service-Card-Id: 92139755
Service-Version: 1.20
DHowett added a commit that referenced this pull request Mar 20, 2024
The 14.39 compiler seems pretty busted.

Refs #16794

(cherry picked from commit ff47e0c)
Service-Card-Id: 92139754
Service-Version: 1.19
@Karl-WE
Copy link

Karl-WE commented Mar 26, 2024

"We've rolled back to an older compiler to get Terminal working on Intel Core 2 Duo machines again (!) "
That's a noble gesture.

Would not consider these CPUs and platforms being secure and running supported OS anymore (soon).

@DHowett
Copy link
Member Author

DHowett commented Mar 26, 2024

soon

Soon, but not yet. Windows 10 still supports them, and given that we must run on Windows 10... 🙂

This also fixed a bunch of other more insidious compiler issues around shifts and masks that have just been causing havoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Cherry Picked
Development

Successfully merging this pull request may close these issues.

4 participants