Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade version of Selenium #17045

Closed
wants to merge 10 commits into from
Closed

Upgrade version of Selenium #17045

wants to merge 10 commits into from

Conversation

skanda890
Copy link

@skanda890 skanda890 commented Apr 11, 2024 •
edited
Loading

Summary of the Pull Request

This reduces vulnerabilities.

References and Relevant Issues

This closes #17048

Detailed Description of the Pull Request / Additional Comments

Validation Steps Performed

PR Checklist

snyk-bot and others added 7 commits April 10, 2024 05:59
@snyk-bot
fix: dep/nuget/packages.config to reduce vulnerabilities
86129f9 
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-DOTNET-SELENIUMWEBDRIVER-6062317
@skanda890
Merge pull request #1 from skanda890/snyk-fix-3ceeb9042d327cfb34a399a…
a7ee32d 
…b31049e79

[Snyk] Security upgrade Selenium.WebDriver from 3.5.0 to 4.14.1
@skanda890
Merge branch 'microsoft:main' into main
e67bde3
@skanda890
Update packages.config
50da9ba 
Changing Version of Selenium WebDriver
@snyk-bot
fix: dep/nuget/packages.config to reduce vulnerabilities
a8242ee 
The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-DOTNET-SELENIUMWEBDRIVER-6062317
@skanda890
Update packages.config
19c8bde
@skanda890
Merge pull request #2 from skanda890/snyk-fix-3ceeb9042d327cfb34a399a…
3da16d3 
…b31049e79

[Snyk] Security upgrade Selenium.WebDriver from 4.10.0 to 4.14.1
DHowett
DHowett requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! Selenium 4 is incompatible with WinAppDriver (the testing solution we use) and it will therefore not work with our project. If you're going to upgrade dependencies--especially between major versions--please make sure that you've completed a local build and test cycle!

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Apr 11, 2024
@skanda890
Copy link
Author

Hey there! Selenium 4 is incompatible with WinAppDriver (the testing solution we use) and it will therefore not work with our project. If you're going to upgrade dependencies--especially between major versions--please make sure that you've completed a local build and test cycle!

Then which version does it support?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Apr 11, 2024
skanda890
skanda890 commented Apr 12, 2024
View reviewed changes
Copy link
Author

@skanda890 skanda890 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now WinAppDriver supports Selenium.

@DHowett
Copy link
Member

DHowett commented Jun 20, 2024

Thanks for this! We're moving nuget feeds, so we will re-evaluate our dependencies at that time.

@DHowett DHowett closed this Jun 20, 2024
@skanda890
Copy link
Author

skanda890 commented Jun 24, 2024 •
edited
Loading

I wonder if Selenium 3.142.7 works with WinAppDriver.

@skanda890
Copy link
Author

microsoft/WinAppDriver#1839

@skanda890
Copy link
Author

skanda890 commented Jun 24, 2024 •
edited
Loading

I wonder if Selenium 3.142.7 works with WinAppDriver.

Does anyone know if this is true?

image

@skanda890 skanda890 changed the title fix: dep/nuget/packages.config to reduce vulnerabilities Upgrade version of Selenium Jun 24, 2024
@DHowett
Copy link
Member

DHowett commented Jun 24, 2024

I'm not involved with WinAppDriver any longer, and I cannot vouch for the veracity of any information generated by that... thing.

@skanda890
Copy link
Author

I'm not involved with WinAppDriver any longer, and I cannot vouch for the veracity of any information generated by that... thing.

Do you know anyone who is involved with WinAppDriver.

@DHowett
Copy link
Member

DHowett commented Jun 27, 2024

I do not, I am sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett requested changes

Assignees
No one assigned
Labels
Needs-Attention The core contributors need to come back around and look at this ASAP.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade Selenium version
3 participants
@skanda890 @DHowett @snyk-bot