Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TerminalPage not being released on window close #17107

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Apr 23, 2024

Because this holds onto the root element, TerminalPage gets "leaked"
on Windows 10 when a window is closed until another is opened.

Validation Steps Performed

  • Set a breakpoint in Renderer::~Renderer
  • Open and close a window
  • Breakpoint used to not get hit and now it does ✅

@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Windowing Window frame, quake mode, tearout labels Apr 23, 2024
@lhecker lhecker added this to the Terminal v1.21 milestone Apr 23, 2024
@DHowett DHowett added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit a590a1b Apr 23, 2024
20 checks passed
@DHowett DHowett deleted the dev/lhecker/window-leak branch April 23, 2024 16:50
DHowett pushed a commit that referenced this pull request Apr 23, 2024
Because this holds onto the root element, `TerminalPage` gets "leaked"
on Windows 10 when a window is closed until another is opened.

## Validation Steps Performed
* Set a breakpoint in `Renderer::~Renderer`
* Open and close a window
* Breakpoint used to not get hit and now it does ✅

(cherry picked from commit a590a1b)
Service-Card-Id: 92407667
Service-Version: 1.20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
Development

Successfully merging this pull request may close these issues.

3 participants