-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for local snippets in the CWD #17388
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
ae705f3
Squashed commit of the following:
zadjii-msft d71cb89
Merge remote-tracking branch 'origin/main' into dev/migrie/f/local-sn…
zadjii-msft 73bb68c
spel
zadjii-msft 99f1cc6
Merge remote-tracking branch 'origin/main' into dev/migrie/f/local-sn…
zadjii-msft 3d7e114
Merge remote-tracking branch 'origin/main' into dev/migrie/f/local-sn…
zadjii-msft 81b77bf
this does work
zadjii-msft c7b6b6f
cleanup
zadjii-msft 7fbf2a3
Merge remote-tracking branch 'origin/main' into dev/migrie/f/local-sn…
zadjii-msft c0f4e84
Merge remote-tracking branch 'origin/main' into dev/migrie/f/local-sn…
zadjii-msft 6dfbe5b
ew
zadjii-msft a5fcc83
better
zadjii-msft b2f276b
more better...
zadjii-msft 6f3609f
best locking
zadjii-msft 73e0329
Merge remote-tracking branch 'origin/main' into dev/migrie/f/local-sn…
zadjii-msft b8bfb2d
Merge remote-tracking branch 'origin/main' into dev/migrie/f/local-sn…
zadjii-msft 0605b61
coulda swore we needed to stdmove into winrt arrays
zadjii-msft c58b823
format
zadjii-msft 2517200
nits
zadjii-msft 7b1df6c
Merge branch 'dev/migrie/f/local-snippets-final-FINAL' of https://git…
zadjii-msft 06c0e66
Merge remote-tracking branch 'origin/main' into dev/migrie/f/local-sn…
zadjii-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"$version": "1.0.0", | ||
"snippets": | ||
[ | ||
{ | ||
"input": "bx\r", | ||
"name": "Build project", | ||
"description": "Build the project in the CWD" | ||
}, | ||
{ | ||
"input": "bz\r", | ||
"name": "Build solution, incremental", | ||
"description": "Just build changes to the solution" | ||
}, | ||
{ | ||
"input": "bcz\r", | ||
"name": "Clean & build solution", | ||
"icon": "\uE8e6", | ||
"description": "Start over. Go get your coffee. " | ||
}, | ||
{ | ||
"input": "nuget push -ApiKey az -source TerminalDependencies %userprofile%\\Downloads", | ||
"name": "Upload package to nuget feed", | ||
"icon": "\uE898", | ||
"description": "Go download a .nupkg, put it in ~/Downloads, and use this to push to our private feed." | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: always prefer
{}
for hstrings. no need to have empty string literals all over the place.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've previously raised a
nit
about how I personally think that{}
is perfect for object constructions, while=
is perfect for assignments, in particular of trivial types. I know you all like to writeauto foo{ bar() }
, so I feel quite betrayed seeing this!(This is not a serious comment. 😄)