Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize all SixelParser members #17497

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Initialize all SixelParser members #17497

merged 1 commit into from
Jul 1, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Jul 1, 2024

Assuming we do have a bug somewhere, initializing these members
will allow us to consistently reproduce the bug, whereas without
the initialization the member values will all be random and so
they may result in random behavior which would make finding the
root cause more difficult (or at least less consistent).

@lhecker lhecker added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Jul 1, 2024
@lhecker lhecker force-pushed the dev/lhecker/sixel-fixup branch from bf20ed6 to b532dcc Compare July 1, 2024 12:09
@DHowett DHowett added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 9cc0eba Jul 1, 2024
20 checks passed
@DHowett DHowett deleted the dev/lhecker/sixel-fixup branch July 1, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants