Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema and user defaults from Action ID change #17509

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

PankajBhojwani
Copy link
Contributor

  • Remove the deprecated flag for the keybindings array now that we have re-added that
  • Update userDefaults to use the correct ID for the Copy command

@zadjii-msft zadjii-msft enabled auto-merge July 3, 2024 13:39
@zadjii-msft zadjii-msft added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit ec92892 Jul 3, 2024
20 checks passed
@zadjii-msft zadjii-msft deleted the dev/pabhoj/action_id_fixes branch July 3, 2024 14:32
@GitMurf
Copy link

GitMurf commented Sep 7, 2024

Is there any documentation on the keybindings deprecation / re-add? I have a need to switch between Windows Terminal Stable and Preview/Canary fairly often but historically have tried to keep my settings.json for each of them somewhat in sync. Recently I started getting weird behaviors where in some settings files I get a LSP deprecation warning (and autocomplete shows keybindings deprecated) and in others I do not.

Do you have any suggestions (or documentation) on how we should handle things going forward and what this all means? For example, what is the purpose now of bringing keybindings back? Am I able to just ONLY use actions and not keybindings to keep my settings.json files backwards compatible with each other?

Thanks in advance!

@lhecker
Copy link
Member

lhecker commented Sep 9, 2024

Backwards compatibility of our settings files (i.e. using a Canary settings file with Stable) is not something we've been planning to support so far. Because of that, you'd have to make your changes to your settings in Stable and then copy the changed file to Preview/Canary, not the other way around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants