Fix qps-ploc generation for store translations #17526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-Build
lhecker
commented
Jul 8, 2024
| Get-ChildItem -Recurse -Filter *.resw | ||
| | Where-Object { $_.Directory.Name.StartsWith("qps-ploc") } | ||
| Get-ChildItem -Recurse -Directory -Filter qps-ploc* | ||
| | Get-ChildItem -Include *.resw,*.xml |
There was a problem hiding this comment.
Suppress whitespace changes: https://github.com/microsoft/terminal/pull/17526/files?w=1
lhecker
commented
Jul 8, 2024
| $newValue += $padding.Substring(0, $paddingLength) | ||
| $value += $padding.Substring(0, $paddingLength) | ||
| return $value | ||
| } |
There was a problem hiding this comment.
Both functions are identical to the code that was previously in the loop below.
zadjii-msft
approved these changes
Jul 8, 2024
DHowett
approved these changes
Jul 8, 2024
| $entry.value = $newValue | ||
| } | ||
| } elseif ($path.EndsWith(".xml")) { | ||
| foreach ($entry in $content.DocumentElement.SelectNodes('//*[@_locID]/text()')) { |
There was a problem hiding this comment.
technically Locked exists in this format too; do we not have any?
There was a problem hiding this comment.
Ah, we actually do.
57: <!-- _locComment_text="{MaxLength=1500} {Locked=__VERSION_NUMBER__} App Release Note" -->Version __VERSION_NUMBER
There was a problem hiding this comment.
Ah f... Let me try to fix that.
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
DHowett
approved these changes
Jul 8, 2024
DHowett
pushed a commit
that referenced
this pull request
Jul 8, 2024
This fixes some more issues not properly covered by #17526: * Fixed `_locComment_text` comments being effectively ignored. * Fixed line splitting of comments (CRLF vs LF). * Fixed BOM suppression. * Fixed support for having multiple `{Locked=...}` comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate-PseudoLocalizations.ps1to find the .xml files.(As opposed to .resw for the other translations.)
and stripping comments/attributes as needed.
PreserveWhitespaceduring XML loading.Validation Steps Performed
Ran it locally and compared the results. ✅