Add ITerminalHandoff3 in preparation for overlapped pipes #17575
Conversation
lhecker
added
the
Product-Conpty
| _cols{ 80 }, | ||
| _inPipe{ hIn }, | ||
| _outPipe{ hOut } | ||
| // Who decided that? |
| GetExitCodeProcess(_piClient.hProcess, &exitCode); | ||
|
|
||
| // Signal the closing or failure of the process. | ||
| // exitCode might be STILL_ACTIVE if a client has called FreeConsole() and | ||
| // thus caused the tab to close, even though the CLI app is still running. | ||
| const auto success = exitCode == 0 || exitCode == STILL_ACTIVE || exitCode == STATUS_CONTROL_C_EXIT; |
There was a problem hiding this comment.
honestly I was actually fine w/ this change - I just thought the exitcode one was weird! sorry!!
There was a problem hiding this comment.
Nah, we can do such changes later, when they're necessary. 🙂
| @@ -111,8 +111,8 @@ | |||
| <com:ComInterface> | |||
| <com:ProxyStub Id="1D1852F4-ADAD-42B6-9A43-9437AAAD7717" DisplayName="OpenConsoleHandoffProxy" Path="OpenConsoleProxy.dll"/> | |||
| <com:Interface Id="E686C757-9A35-4A1C-B3CE-0BCC8B5C69F4" ProxyStubClsid="1D1852F4-ADAD-42B6-9A43-9437AAAD7717"/> | |||
| <com:Interface Id="59D55CCE-FC8A-48B4-ACE8-0A9286C6557F" ProxyStubClsid="1D1852F4-ADAD-42B6-9A43-9437AAAD7717"/> <!-- ITerminalHandoff --> | |||
There was a problem hiding this comment.
Shouldn't we keep the old ITerminalHandoff around? Isn't that just good practice?
There was a problem hiding this comment.
This interface is essentially an internal currency between OpenConsole and the terminal. It doesn't need to support all interfaces. And after this PR OpenConsole will only support ITerminalHandoff3.
But Dustin "Human Wikipedia" Howett explained me how stubs work and basically per user there can only be 1 single COM proxy stub instance for Windows Terminal. So, if the Windows Terminal Canary stub gets installed and it only supported ITerminalHandoff3 then any older version of Windows Terminal that only supports ITerminalHandoff2 would not work anymore.
However, there's some mapping from interface GUIs to proxies so it may just work to remove them anyway. He said we should just try it.
| // Duplicate the handles from what we received. | ||
| // The contract with COM specifies that any HANDLEs we receive from the caller belong | ||
| // to the caller and will be freed when we leave the scope of this method. | ||
| // Making our own duplicate copy ensures they hang around in our lifetime. | ||
| THROW_IF_FAILED(_duplicateHandle(in, in)); | ||
| THROW_IF_FAILED(_duplicateHandle(out, out)); | ||
| THROW_IF_FAILED(_duplicateHandle(signal, signal)); | ||
| THROW_IF_FAILED(_duplicateHandle(ref, ref)); | ||
| THROW_IF_FAILED(_duplicateHandle(server, server)); | ||
| THROW_IF_FAILED(_duplicateHandle(client, client)); |
There was a problem hiding this comment.
📝 got moved to ConptyConnection::InitializeFromHandoff
Without a renderer in #17510 we cannot skip "frames" anymore.
As such, using overlapped IO becomes crucial to avoid a regression
in performance. ITerminalHandoff3 fixes this by allowing the terminal
to pick the pipes it wants, which mirrors CreatePseudoConsole
where the caller can also pick its own pipes.
Validation Steps Performed