build: switch back to the "latest" OneBranch build image #17630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to a string of compiler bugs, we had to use an older container image that shipped with VS 17.9. Unfortunately, that container image is falling further and further out of date. The build agents don't cache it any longer, so they spend 30-45 minutes of every build pulling it from the registry. With the changes to ConPTY in #xxxxx removing the need for til::bitmap, we no longer need to work around the compiler bugs it exposed. Furthermore, 17.10.6+ has a much more robust and presumably "working" compiler.
|
Then again, 14.40.33807 still fails for #16595. But that's a different issue. We can try this in Canary and see how it goes. |
DHowett
changed the title
DHowett
added a commit
that referenced
this pull request
Jul 31, 2024
)" This reverts commit 39108a7.
DHowett
added a commit
that referenced
this pull request
Aug 23, 2024
Thanks to a string of compiler bugs, we had to use an older container image that shipped with VS 17.9. Unfortunately, that container image is falling further and further out of date. The build agents don't cache it any longer, so they spend 30-45 minutes of every build pulling it from the registry. With the changes to ConPTY in #17510 removing the need for til::bitmap, we no longer need to work around the compiler bugs it exposed. Furthermore, 17.10.6+ has a much more robust and presumably "working" compiler. (cherry picked from commit 39108a7) Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgSI7RU Service-Version: 1.21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to a string of compiler bugs, we had to use an older container image that shipped with VS 17.9.
Unfortunately, that container image is falling further and further out of date. The build agents don't cache it any longer, so they spend 30-45 minutes of every build pulling it from the registry.
With the changes to ConPTY in #17510 removing the need for til::bitmap, we no longer need to work around the compiler bugs it exposed.
Furthermore, 17.10.6+ has a much more robust and presumably "working" compiler.